You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@bahir.apache.org by ckadner <gi...@git.apache.org> on 2017/04/25 05:55:33 UTC
[GitHub] bahir-flink pull request #15: [BAHIR-111] Correcting imports of o.a.f.table....
GitHub user ckadner opened a pull request:
https://github.com/apache/bahir-flink/pull/15
[BAHIR-111] Correcting imports of o.a.f.table.api.*
Issue link: [BAHIR-111: IntelliJ reports compilation error for flink-connector-netty](https://issues.apache.org/jira/browse/BAHIR-111)
This change addresses the following compilation error in IntelliJ:
```
Information:4/24/17, 4:25 PM - Compilation completed with 3 errors and 1 warning in 4s 337ms
Warning:scalac: there was one feature warning; re-run with -feature for details
.../flink-connector-netty/src/test/scala/org/apache/flink/streaming/connectors/netty/example/StreamSqlExample.scala
Error:Error:line (22)object table is not a member of package org.apache.flink.api.scala
import org.apache.flink.api.scala.table._
Error:Error:line (23)object table is not a member of package org.apache.flink.api
import org.apache.flink.api.table.TableEnvironment
Error:Error:line (45)not found: value TableEnvironment
val tEnv = TableEnvironment.getTableEnvironment(env)
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ckadner/bahir-flink patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bahir-flink/pull/15.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15
----
commit 68d22c4cfd694cfbb1f4c80d5f1c4d0a4ae39521
Author: Christian Kadner <ck...@users.noreply.github.com>
Date: 2017-04-25T05:51:48Z
[BAHIR-111] Correcting imports of o.a.f.table.api.*
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir-flink issue #15: [BAHIR-111] Correcting imports of o.a.f.table.api.*
Posted by ckadner <gi...@git.apache.org>.
Github user ckadner commented on the issue:
https://github.com/apache/bahir-flink/pull/15
@shijinkui -- since you contributed the `StreamSqlExample` could you please verify this fix? Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir-flink pull request #15: [BAHIR-111] Correcting imports of o.a.f.table....
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/bahir-flink/pull/15
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir-flink issue #15: [BAHIR-111] Correcting imports of o.a.f.table.api.*
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on the issue:
https://github.com/apache/bahir-flink/pull/15
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir-flink issue #15: [BAHIR-111] Correcting imports of o.a.f.table.api.*
Posted by shijinkui <gi...@git.apache.org>.
Github user shijinkui commented on the issue:
https://github.com/apache/bahir-flink/pull/15
@ckadner Sorry for get the message late. Thanks for your verify.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---