You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/24 16:09:40 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #8438:
[FLINK-12152] Make the vcore that Application Master used configurable for
Flink on YARN
tillrohrmann commented on a change in pull request #8438: [FLINK-12152] Make the vcore that Application Master used configurable for Flink on YARN
URL: https://github.com/apache/flink/pull/8438#discussion_r287425131
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
##########
@@ -229,6 +229,13 @@ private void isReadyForDeployment(ClusterSpecification clusterSpecification) thr
throw new YarnDeploymentException("Flink configuration object has not been set");
}
+ int configuredAmVcores = flinkConfiguration.getInteger(YarnConfigOptions.APP_MASTER_VCORES);
+ if (configuredAmVcores < YarnConfigOptions.APP_MASTER_VCORES.defaultValue()) {
Review comment:
I think we should compare `configuredAmVcores` against `numYarnMaxVcores` which we calculate a bit further down. I think we don't have to check that we request fewer cores than `1` because it won't take any effect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services