[jira] [Commented] (LUCENE-6180) Make BitsSlice public (not package-private)

["Michael McCandless (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-6180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275824#comment-14275824 ] 

Michael McCandless commented on LUCENE-6180:
--------------------------------------------

This is a rather internal class?  If we do move to util and make it public I think it should remain @lucene.internal?

I also don't like that it ... encourages top-level reader usage.  Lucene only uses this for merging I think.

What sort of times did you need to use it?

> Make BitsSlice public (not package-private)
> -------------------------------------------
>
>                 Key: LUCENE-6180
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6180
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: David Smiley
>            Priority: Minor
>
> org.apache.lucene.index.BitsSlice is a simple and generic utility class. I've found a need to use and it'd be nice if it were public but it's currently package-private.  It should go to the util package, and the constructor taking ReaderSlice cold be removed.
> In Java 8, it'd be neat to have a Bits.subSlice default method simply calling-out to this but no big deal.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org