You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by andreaTP <gi...@git.apache.org> on 2017/03/03 10:45:51 UTC
[GitHub] zeppelin pull request #2093: Env variable to configure maven central repo
GitHub user andreaTP opened a pull request:
https://github.com/apache/zeppelin/pull/2093
Env variable to configure maven central repo
### What is this PR for?
When deploying Zeppelin in private Cloud or within closed networks, it happens that Maven Central isn't directly reachable, so we want to configure our own proxy and do not have to wait for minutes long timeouts when importing external libraries. It is anyhow worth to let user configure maven central repo instead of hardcoding the URL.
### What type of PR is it?
Improvement
### How should this be tested?
Outline the steps to test the PR here.
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andreaTP/zeppelin mavenRepo
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2093.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2093
----
commit 216144fcb6e52fe6db95afdfef4fde68e601ca4e
Author: Andrea Peruffo <an...@gmail.com>
Date: 2017-03-03T10:44:15Z
Env variable to configure maven central repo
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2093: [ZEPPELIN-2277] Env variable to configure maven centra...
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2093
updated also commit message here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2093: [ZEPPELIN-2277] Env variable to configure maven centra...
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2093
Thanks a lot! appreciated this welcoming environment! (I was aiming to become committer number 200 also )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2093: [ZEPPELIN-2277] Env variable to configure maven centra...
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2093
Yep, opened Jira issue and linked accordingly on PR title.
https://issues.apache.org/jira/browse/ZEPPELIN-2277
@Leemoonsoo thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2093: Env variable to configure maven central repo
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2093
ok, I don't know exactly how to proceed on debugging this :-S, the problem is with dependency loading in python interpreter...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2093: [ZEPPELIN-2277] Env variable to configure maven...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2093
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2093: Env variable to configure maven central repo
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2093
I believe this is ready to merge.
Please let me know if I need to do anything more.
cc. @Leemoonsoo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2093: Env variable to configure maven central repo
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2093
@Leemoonsoo thanks a lot for the hints, this simplify a lot and even CI is happy.
I already squashed commits since now this PR looks in a good shape, but feel free to ask/argue about anything else.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2093: Env variable to configure maven central repo
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2093
Not sure how to debug the CI failure, https://travis-ci.org/andreaTP/zeppelin/jobs/207318026
help needed please :-) sorry I'm new in this codebase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2093: Env variable to configure maven central repo
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2093
Thanks @andreaTP for the contribution.
I left some comment. Please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2093: Env variable to configure maven central repo
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2093
added even the row in the configuration table, thanks a lot for your patience!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2093: Env variable to configure maven central repo
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2093
@Leemoonsoo thanks a lot for your comments, I hope to have targeted all of them, not sure how it works here, I will squash commits at the end of the process if you agree.
b.t.w.
tests consistently fail at ```pySparkDepLoaderTest``` https://travis-ci.org/andreaTP/zeppelin/jobs/208145522#L2932 but don't know how to start debugging this, it immediately fail with reflection errors.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2093: Env variable to configure maven central repo
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2093
Thanks for pinging.
LGTM and merge to master if no further discussions.
Meanwhile, @andreaTP do you mind create a JIRA issue?
So later, everyone can more easily track when this feature has beed added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---