You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by soralee <gi...@git.apache.org> on 2016/12/29 12:28:45 UTC

[GitHub] zeppelin pull request #1820: [ZEPPELIN-1841] Some of shortcut key is not wor...

GitHub user soralee opened a pull request:

    https://github.com/apache/zeppelin/pull/1820

    [ZEPPELIN-1841] Some of shortcut key is not working

    ### What is this PR for?
    Some of note shortcut key is not working on Ubuntu.
    
    ### What type of PR is it?
    [ Bug Fix ]
    
    ### Todos
    * N/A
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-1841
    
    ### How should this be tested?
    If you don't have keyboard shortcut in your OS system, please test shortcut key in paragraph like the following key and check work well.
    
    ```
    Ctrl + Alt + a : Insert new paragraph above
    Ctrl + Alt + k : Move paragraph Up
    Ctrl + Alt + e : Toggle editor
    Ctrl + Alt + t : Toggle title
    ```
    
    ### Screenshots (if appropriate)
     - Ctrl + Alt + a : Insert new paragraph above
    ![z1841_a](https://cloud.githubusercontent.com/assets/8110458/21543796/ea98a83e-ce0c-11e6-84b6-bab09964d40a.gif)
    
     - Ctrl + Alt + k : Move paragraph Up
    ![z1841_k](https://cloud.githubusercontent.com/assets/8110458/21543837/41158fc4-ce0d-11e6-8338-102a28b816bf.gif)
    
     - Ctrl + Alt + e : Toggle editor
    ![z1841_e](https://cloud.githubusercontent.com/assets/8110458/21543845/57cc980c-ce0d-11e6-86d6-9f232ee336f9.gif)
    
     - Ctrl + Alt + t : Toggle title
    ![z1841_t](https://cloud.githubusercontent.com/assets/8110458/21543849/5c2d6282-ce0d-11e6-9b73-ce1df437b87d.gif)
    
    
    ### Questions:
    * Does the licenses files need update? N/A
    * Is there breaking changes for older versions? N/A
    * Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soralee/zeppelin ZEPPELIN-1841

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1820.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1820
    
----
commit 3cd53a02ba7109a028836a75618e0bfccf2d0afc
Author: soralee <so...@nflabs.com>
Date:   2016-12-29T11:54:37Z

    [ZEPPELIN-1841] shortcut key is not working on Ubuntu

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1820: [ZEPPELIN-1841] Some of shortcut key is not working

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1820
  
    LGTM and merge to master if there're no further comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1820: [ZEPPELIN-1841] Some of shortcut key is not wor...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1820


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1820: [ZEPPELIN-1841] Some of shortcut key is not wor...

Posted by soralee <gi...@git.apache.org>.
GitHub user soralee reopened a pull request:

    https://github.com/apache/zeppelin/pull/1820

    [ZEPPELIN-1841] Some of shortcut key is not working

    ### What is this PR for?
    Some of note shortcut key is not working on Ubuntu.
    
    ### What type of PR is it?
    [ Bug Fix ]
    
    ### Todos
    * N/A
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-1841
    
    ### How should this be tested?
    If you don't have keyboard shortcut in your OS system, please test shortcut key in paragraph like the following key and check work well.
    
    ```
    Ctrl + Alt + a : Insert new paragraph above
    Ctrl + Alt + k : Move paragraph Up
    Ctrl + Alt + e : Toggle editor
    Ctrl + Alt + t : Toggle title
    ```
    
    ### Screenshots (if appropriate)
     - Ctrl + Alt + a : Insert new paragraph above
    ![z1841_a](https://cloud.githubusercontent.com/assets/8110458/21543796/ea98a83e-ce0c-11e6-84b6-bab09964d40a.gif)
    
     - Ctrl + Alt + k : Move paragraph Up
    ![z1841_k](https://cloud.githubusercontent.com/assets/8110458/21543837/41158fc4-ce0d-11e6-8338-102a28b816bf.gif)
    
     - Ctrl + Alt + e : Toggle editor
    ![z1841_e](https://cloud.githubusercontent.com/assets/8110458/21543845/57cc980c-ce0d-11e6-86d6-9f232ee336f9.gif)
    
     - Ctrl + Alt + t : Toggle title
    ![z1841_t](https://cloud.githubusercontent.com/assets/8110458/21543849/5c2d6282-ce0d-11e6-9b73-ce1df437b87d.gif)
    
    
    ### Questions:
    * Does the licenses files need update? N/A
    * Is there breaking changes for older versions? N/A
    * Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soralee/zeppelin ZEPPELIN-1841

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1820.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1820
    
----
commit 3cd53a02ba7109a028836a75618e0bfccf2d0afc
Author: soralee <so...@nflabs.com>
Date:   2016-12-29T11:54:37Z

    [ZEPPELIN-1841] shortcut key is not working on Ubuntu

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1820: [ZEPPELIN-1841] Some of shortcut key is not wor...

Posted by soralee <gi...@git.apache.org>.
Github user soralee closed the pull request at:

    https://github.com/apache/zeppelin/pull/1820


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1820: [ZEPPELIN-1841] Some of shortcut key is not working

Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/1820
  
    Thank you @Leemoonsoo !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---