[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #510: Tab name to be the filepath of the file being edited

["scholarsmate (via GitHub)" <gi...@apache.org>]

scholarsmate commented on code in PR #510:
URL: https://github.com/apache/daffodil-vscode/pull/510#discussion_r1144736083


##########
src/omega_edit/client.ts:
##########
@@ -142,8 +142,7 @@ export function activate(ctx: vscode.ExtensionContext) {
       'extension.data.edit',
       async (
         startServ: boolean = true,
-        port: number | undefined = undefined,
-        fileToEdit: string = ''

Review Comment:
   I'm not happy with having this testing cruft in the shipped project.  I've reverted it _temporarily_ and will revisit later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org