You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "snazy (via GitHub)" <gi...@apache.org> on 2025/11/03 17:43:24 UTC
[PR] Build/nit: cache output of `generatedMarkdownDocs` [polaris]
snazy opened a new pull request, #2967:
URL: https://github.com/apache/polaris/pull/2967
`(Java)Exec` tasks are not cacheable by default, as annotated with `@DisableCachingByDefault`. Adding an `outputs.cacheIf { true }` enables caching on those tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build/nit: cache output of `generatedMarkdownDocs` [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on code in PR #2967:
URL: https://github.com/apache/polaris/pull/2967#discussion_r2487704815
##########
tools/config-docs/site/build.gradle.kts:
##########
@@ -53,6 +53,7 @@ val generatedMarkdownDocs = tasks.register<JavaExec>("generatedMarkdownDocs") {
mainClass = "org.apache.polaris.docs.generator.ReferenceConfigDocsGenerator"
+ outputs.cacheIf { true }
Review Comment:
correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build/nit: cache output of `generatedMarkdownDocs` [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy merged PR #2967:
URL: https://github.com/apache/polaris/pull/2967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build/nit: cache output of `generatedMarkdownDocs` [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2967:
URL: https://github.com/apache/polaris/pull/2967#discussion_r2487361688
##########
tools/config-docs/site/build.gradle.kts:
##########
@@ -53,6 +53,7 @@ val generatedMarkdownDocs = tasks.register<JavaExec>("generatedMarkdownDocs") {
mainClass = "org.apache.polaris.docs.generator.ReferenceConfigDocsGenerator"
+ outputs.cacheIf { true }
Review Comment:
Just for my education 😅 : even with `cacheIf { true }` the files are still subject to normal source/target modifications checks, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org