You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Buğra Gedik (JIRA)" <ji...@apache.org> on 2018/10/11 21:13:00 UTC
[jira] [Comment Edited] (THRIFT-3143) add typescript directory
support
[ https://issues.apache.org/jira/browse/THRIFT-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647042#comment-16647042 ]
Buğra Gedik edited comment on THRIFT-3143 at 10/11/18 9:12 PM:
---------------------------------------------------------------
Hey [~jking3], as Unscrambl we are planning to revive this and support the {{-gen js:node,ts}} option (JS code targeted at node.js, with TS type mappings) given that the following are already supported: {{-gen js}} (JS code for browsers), {{-gen js:ts}} (JS code for browsers with TS type mappings), and {{-gen js:node}} (JS code for node.js). The existing PR mentioned here attempted to create a separate code generator, which seems wrong. It seems it was abandoned.
I assume you'll be open to this. Are there any other plans for supporting JS code generation for node.js with TS type mappings?
was (Author: bgedik):
Hey [~jking3], as Unscrambl we are planning to revive this and support the {{{{-gen js:node,ts}}}} option (JS code targeted at node.js, with TS type mappings) given that the following are already supported: {{{{-gen js}}}} (JS code for browsers), {{{{-gen js:ts}}}} (JS code for browsers with TS type mappings), and {{{{-gen js:node}}}} (JS code for node.js). The existing PR mentioned here attempted to create a separate code generator, which seems wrong. It seems it was abandoned.
I assume you'll be open to this. Are there any other plans for supporting JS code generation for node.js with TS type mappings?
> add typescript directory support
> --------------------------------
>
> Key: THRIFT-3143
> URL: https://issues.apache.org/jira/browse/THRIFT-3143
> Project: Thrift
> Issue Type: New Feature
> Components: Node.js - Compiler
> Reporter: Kazuki Yasufuku
> Priority: Major
>
> Current typescript support is only work for browser, and generated d.ts uses internal module.
> So, it's hard to use for typescript in node.js.
> To solve probrem, I make a pull request that generate typescript code directory.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)