You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by Raymond Feng <en...@gmail.com> on 2009/10/08 21:12:25 UTC

Re: svn commit: r823219 - in /tuscany/java/sca/modules: binding-atom-runtime/META-INF/MANIFEST.MF data-api/META-INF/MANIFEST.MF

Hi,

Require-Bundle header is strongly discouraged as it creates hard dependency 
from one bundle to the other by name. Import-Package should be used instead 
so that the dependency is narrowed to the package which can be supplied by a 
bundle (not tied to it).

Thanks,
Raymond
--------------------------------------------------
From: <lr...@apache.org>
Sent: Thursday, October 08, 2009 9:11 AM
To: <co...@tuscany.apache.org>
Subject: svn commit: r823219 - in /tuscany/java/sca/modules: 
binding-atom-runtime/META-INF/MANIFEST.MF data-api/META-INF/MANIFEST.MF

> Author: lresende
> Date: Thu Oct  8 16:11:42 2009
> New Revision: 823219
>
> URL: http://svn.apache.org/viewvc?rev=823219&view=rev
> Log:
> Fixing up Atom Binding manifest imports
>
> Modified:
>    tuscany/java/sca/modules/binding-atom-runtime/META-INF/MANIFEST.MF
>    tuscany/java/sca/modules/data-api/META-INF/MANIFEST.MF
>
> Modified: 
> tuscany/java/sca/modules/binding-atom-runtime/META-INF/MANIFEST.MF
> URL: 
> http://svn.apache.org/viewvc/tuscany/java/sca/modules/binding-atom-runtime/META-INF/MANIFEST.MF?rev=823219&r1=823218&r2=823219&view=diff
> ==============================================================================
> --- tuscany/java/sca/modules/binding-atom-runtime/META-INF/MANIFEST.MF 
> (original)
> +++ tuscany/java/sca/modules/binding-atom-runtime/META-INF/MANIFEST.MF Thu 
> Oct  8 16:11:42 2009
> @@ -18,6 +18,8 @@
>  org.apache.abdera.i18n.iri,
>  org.apache.abdera.model,
>  org.apache.abdera.parser,
> + org.apache.abdera.protocol.client,
> + org.apache.abdera.protocol.client.util,
>  org.apache.abdera.writer,
>  org.apache.commons.codec.binary,
>  org.apache.commons.httpclient,
> @@ -40,4 +42,5 @@
>  org.oasisopen.sca.annotation;version="2.0.0"
> Bundle-SymbolicName: org.apache.tuscany.sca.binding.atom.abdera
> Bundle-DocURL: http://www.apache.org/
> +Require-Bundle: org.apache.abdera.abdera-core
>
>
> Modified: tuscany/java/sca/modules/data-api/META-INF/MANIFEST.MF
> URL: 
> http://svn.apache.org/viewvc/tuscany/java/sca/modules/data-api/META-INF/MANIFEST.MF?rev=823219&r1=823218&r2=823219&view=diff
> ==============================================================================
> --- tuscany/java/sca/modules/data-api/META-INF/MANIFEST.MF (original)
> +++ tuscany/java/sca/modules/data-api/META-INF/MANIFEST.MF Thu Oct  8 
> 16:11:42 2009
> @@ -1,5 +1,5 @@
> Manifest-Version: 1.0
> -Export-Package: org.apache.tuscany.sca.data.collection
> +Export-Package: org.apache.tuscany.sca.data.collection;version="2.0.0"
> Tool: Bnd-0.0.357
> Bundle-Name: Apache Tuscany SCA Data API
> Created-By: 1.6.0_15 (Apple Inc.)
>
> 

Re: svn commit: r823219 - in /tuscany/java/sca/modules: binding-atom-runtime/META-INF/MANIFEST.MF data-api/META-INF/MANIFEST.MF

Posted by Raymond Feng <en...@gmail.com>.
Don't worry. I forgot to tell you that I have fixed it already :-).

Thanks,
Raymond
--------------------------------------------------
From: "Luciano Resende" <lu...@gmail.com>
Sent: Friday, October 09, 2009 12:25 PM
To: <de...@tuscany.apache.org>
Subject: Re: svn commit: r823219 - in /tuscany/java/sca/modules: 
binding-atom-runtime/META-INF/MANIFEST.MF data-api/META-INF/MANIFEST.MF

> On Thu, Oct 8, 2009 at 12:12 PM, Raymond Feng <en...@gmail.com> wrote:
>> Hi,
>>
>> Require-Bundle header is strongly discouraged as it creates hard 
>> dependency
>> from one bundle to the other by name. Import-Package should be used 
>> instead
>> so that the dependency is narrowed to the package which can be supplied 
>> by a
>> bundle (not tied to it).
>>
>
> This was probably a oversight of Eclipse quick fix. I'll look into
> this shortly... just trying to fix another jira issue :)
>
> -- 
> Luciano Resende
> http://people.apache.org/~lresende
> http://lresende.blogspot.com/ 


Re: svn commit: r823219 - in /tuscany/java/sca/modules: binding-atom-runtime/META-INF/MANIFEST.MF data-api/META-INF/MANIFEST.MF

Posted by Luciano Resende <lu...@gmail.com>.
On Thu, Oct 8, 2009 at 12:12 PM, Raymond Feng <en...@gmail.com> wrote:
> Hi,
>
> Require-Bundle header is strongly discouraged as it creates hard dependency
> from one bundle to the other by name. Import-Package should be used instead
> so that the dependency is narrowed to the package which can be supplied by a
> bundle (not tied to it).
>

This was probably a oversight of Eclipse quick fix. I'll look into
this shortly... just trying to fix another jira issue :)

-- 
Luciano Resende
http://people.apache.org/~lresende
http://lresende.blogspot.com/