You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/01/21 14:51:24 UTC

[GitHub] [ozone] JyotinderSingh opened a new pull request #3007: HDDS-6211. [Docs] Image styling on deployed site does not replicate local builds.

JyotinderSingh opened a new pull request #3007:
URL: https://github.com/apache/ozone/pull/3007


   ## What changes were proposed in this pull request?
   
   It was noticed that the images on the ozone docs website are not responsive despite being rendered with the appropriate CSS applied to their shortcode. This problem is not seen when building the website locally.
   
   This might be due to bootstrap CSS classes being loaded after the inline styles and hence overriding them.
   
   This task makes the image shortcode use a built-in bootstrap class for sizing the images down to prevent such conflicts.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-6211
   
   ## How was this patch tested?
   
   NA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] smengcl commented on pull request #3007: HDDS-6211. [Docs] Image styling on deployed site does not replicate local builds.

Posted by GitBox <gi...@apache.org>.
smengcl commented on pull request #3007:
URL: https://github.com/apache/ozone/pull/3007#issuecomment-1022667974


   Thanks @JyotinderSingh for the patch.
   
   When I'm verifying the patch locally, I don't really see any change on the page before and after the patch when scaling (shrinking and extending page width, zooming in and out): http://localhost:1313/feature/prefixfso.html
   
   ```bash
   cd hadoop-hdds/docs
   hugo serve
   ```
   
   But I do notice the CSS of class `img-responsive` includes `max-width: 100%`:
   
   ```css
   // Responsive image
   //
   // Keep images from scaling beyond the width of their parents.
   .img-responsive(@display: block) {
     display: @display;
     max-width: 100%; // Part 1: Set a maximum relative to the parent
     height: auto; // Part 2: Scale the height according to the width, otherwise you get stretching
   }
   ```
   
   So `img-responsive` seems to be the proper way to do this. I am +1 on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] smengcl edited a comment on pull request #3007: HDDS-6211. [Docs] Image styling on deployed site does not replicate local builds.

Posted by GitBox <gi...@apache.org>.
smengcl edited a comment on pull request #3007:
URL: https://github.com/apache/ozone/pull/3007#issuecomment-1022667974


   Thanks @JyotinderSingh for the patch.
   
   When I'm verifying the patch locally, I don't really see any change on the page before and after the patch when scaling (shrinking and extending page width, zooming in and out): http://localhost:1313/feature/prefixfso.html
   
   ```bash
   cd hadoop-hdds/docs
   hugo serve
   ```
   
   But I do notice the CSS of class `img-responsive` includes `max-width: 100%`:
   
   ```css
   // Responsive image
   //
   // Keep images from scaling beyond the width of their parents.
   .img-responsive(@display: block) {
     display: @display;
     max-width: 100%; // Part 1: Set a maximum relative to the parent
     height: auto; // Part 2: Scale the height according to the width, otherwise you get stretching
   }
   ```
   
   And the images on the doc site have indeed lost the hard-coded style somehow: https://ozone.apache.org/docs/1.2.1/feature/prefixfso.html
   
   So `img-responsive` seems to be the proper way to do this. I am +1 on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] rakeshadr merged pull request #3007: HDDS-6211. [Docs] Image styling on deployed site does not replicate local builds.

Posted by GitBox <gi...@apache.org>.
rakeshadr merged pull request #3007:
URL: https://github.com/apache/ozone/pull/3007


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org