You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/10/19 12:08:08 UTC
[GitHub] [phoenix] ArkenKiran commented on a change in pull request #1282: PHOENIX-5215 opentelemetry changes replacing htrace - WIP
ArkenKiran commented on a change in pull request #1282:
URL: https://github.com/apache/phoenix/pull/1282#discussion_r731794647
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
##########
@@ -279,9 +281,7 @@ public void close() throws IOException {
try {
delegate.close();
} finally {
- if (child != null) {
- child.stop();
- }
+ child.end();
Review comment:
@dbwong In general opentelemetry default implementation would return an invalid span (when telemetry is not enabled) or a valid span same goes for startSpan as well. some other implementation might return null. I will add the check again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org