[jira] Commented: (RIVER-301) Move the tests into the JUnit framework inside the main source project

["Jukka Zitting (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RIVER-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674403#action_12674403 ] 

Jukka Zitting commented on RIVER-301:
-------------------------------------

That certainly is one big patch. :-) When moving things around the source tree, it's best to use "svn move" or "svn copy" so that a resulting "svn diff" will only point out that the file was moved instead of including a full copy of the entire file.

You don't seem to have selected the "Grant license to ASF for inclusion in ASF works" option when uploading the patch. Did you just not notice the option? Could you confirm that the code in the patch intended for inclusion under the Apache license?

Anyway, I think we can work from here. I'll start by copying the source directories as you describe. This should make it easier to create a less enormous patch.

> Move the tests into the JUnit framework inside the main source project
> ----------------------------------------------------------------------
>
>                 Key: RIVER-301
>                 URL: https://issues.apache.org/jira/browse/RIVER-301
>             Project: River
>          Issue Type: Task
>          Components: other
>    Affects Versions: AR3
>            Reporter: Tom Hobbs
>         Attachments: River-301.patch.zip
>
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> The tests donated by SUN live in their own source project and are runnable in a format that is unfriendly towards IDEs and new developers to the River project.
> This is the proposal to move the test code, mostly unmodified, into the main source directory whilst shoe-horning it into JUnit 3.  This will allow it to be easily viewable and runnable.  Such a structure will also reduce the code-compile-test cycle since no JARs will have to be created in the middle of the cycle and no long command-line incantations.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.