[GitHub] [tinkerpop] jorgebay commented on issue #1115: Alternative approach to TINKERPOP-2217.

[GitBox <gi...@apache.org>]

jorgebay commented on issue #1115: Alternative approach to TINKERPOP-2217. 
URL: https://github.com/apache/tinkerpop/pull/1115#issuecomment-527827595
 
 
   Thanks for your patch @danielcweber !
   
   I'm not sure the problem you are trying to solve, is it just making the code more readable?
   
   The `Connection` is a low level class, C# doesn't have something like Netty that simplifies sending/receiving with thread safe channels, so IMO its OK to have low level code (queues, CAS ops, ...).
   
   Semaphores have a cost when contended, you can look at the WaitAsync() lock here: https://github.com/dotnet/coreclr/blob/master/src/System.Private.CoreLib/shared/System/Threading/SemaphoreSlim.cs#L623
   
   I would find very hard to +1 a patch like this without any additional tests and/or performance tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services