[GitHub] [hadoop] steveloughran commented on pull request #5342: HDFS-16904. Close webhdfs during TestSymlinkHdfs teardown

["steveloughran (via GitHub)" <gi...@apache.org>]

steveloughran commented on PR #5342:
URL: https://github.com/apache/hadoop/pull/5342#issuecomment-1422976653

   ok, i got this wrong; should have said use o.a.hadoop.utils.IOUtils.closeStream(), because that one logs at debug if an exception is raised; this PR uses the o.a.commons.IOUtils (joy!) so doesn't log on a failure of that close(). The patch still works, but I'd like to be consistent. 
   
   Proposed: a followup patch, same JIRA, which moves to the o.a.h method; i will then backport the pair into branch-3.
   
   sorry for adding extra homework


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org