svn commit: r1477645 - /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/map/AbstractHashedMap.java

[se...@apache.org]

Author: sebb
Date: Tue Apr 30 14:14:40 2013
New Revision: 1477645

URL: http://svn.apache.org/r1477645
Log:
Some Fields can be private

Modified:
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/map/AbstractHashedMap.java

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/map/AbstractHashedMap.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/map/AbstractHashedMap.java?rev=1477645&r1=1477644&r2=1477645&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/map/AbstractHashedMap.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/map/AbstractHashedMap.java Tue Apr 30 14:14:40 2013
@@ -75,6 +75,8 @@ public class AbstractHashedMap<K, V> ext
     /** An object for masking null */
     protected static final Object NULL = new Object();
 
+    // TODO Privatise fields?
+
     /** Load factor, normally 0.75 */
     protected transient float loadFactor;
     /** The size of the map */
@@ -831,7 +833,7 @@ public class AbstractHashedMap<K, V> ext
      */
     protected static class EntrySet<K, V> extends AbstractSet<Map.Entry<K, V>> {
         /** The parent map */
-        protected final AbstractHashedMap<K, V> parent;
+        private final AbstractHashedMap<K, V> parent;
 
         protected EntrySet(final AbstractHashedMap<K, V> parent) {
             super();
@@ -925,7 +927,7 @@ public class AbstractHashedMap<K, V> ext
      */
     protected static class KeySet<K> extends AbstractSet<K> {
         /** The parent map */
-        protected final AbstractHashedMap<K, ?> parent;
+        private final AbstractHashedMap<K, ?> parent;
 
         protected KeySet(final AbstractHashedMap<K, ?> parent) {
             super();
@@ -1009,7 +1011,7 @@ public class AbstractHashedMap<K, V> ext
      */
     protected static class Values<V> extends AbstractCollection<V> {
         /** The parent map */
-        protected final AbstractHashedMap<?, V> parent;
+        private final AbstractHashedMap<?, V> parent;
 
         protected Values(final AbstractHashedMap<?, V> parent) {
             super();
@@ -1131,15 +1133,15 @@ public class AbstractHashedMap<K, V> ext
     protected static abstract class HashIterator<K, V> {
 
         /** The parent map */
-        protected final AbstractHashedMap<K, V> parent;
+        private final AbstractHashedMap<K, V> parent;
         /** The current index into the array of buckets */
-        protected int hashIndex;
+        private int hashIndex;
         /** The last returned entry */
-        protected HashEntry<K, V> last;
+        private HashEntry<K, V> last;
         /** The next entry */
-        protected HashEntry<K, V> next;
+        private HashEntry<K, V> next;
         /** The modification count expected */
-        protected int expectedModCount;
+        private int expectedModCount;
 
         protected HashIterator(final AbstractHashedMap<K, V> parent) {
             super();