You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/28 20:43:44 UTC

[GitHub] srowen commented on a change in pull request #22806: [SPARK-25250][CORE] : On successful completion of a task attempt on a parti…

srowen commented on a change in pull request #22806: [SPARK-25250][CORE] : On successful completion of a task attempt on a parti…
URL: https://github.com/apache/spark/pull/22806#discussion_r244404273
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala
 ##########
 @@ -1319,4 +1328,26 @@ class TaskSchedulerImplSuite extends SparkFunSuite with LocalSparkContext with B
     tsm.handleFailedTask(tsm.taskAttempts.head.head.taskId, TaskState.FAILED, TaskKilled("test"))
     assert(tsm.isZombie)
   }
+  test("SPARK-25250 On successful completion of a task attempt on a partition id, kill other" +
 
 Review comment:
   Nit: blank line above, and please use spaces in the body of the test to break this up into more readable chunks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org