[jira] [Commented] (VELOCITY-850) modificationCheckInterval defaults to zero

["Michael Osipov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/VELOCITY-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315361#comment-16315361 ] 

Michael Osipov commented on VELOCITY-850:
-----------------------------------------

There several issues here which you need to separate:

1. Your issue with the default value. Would you rather expect {{-1}} and no mod check?
2. The type conv is done by ExtProperties. It might be worth to rework this.

Can you split into separate issues?

> modificationCheckInterval defaults to zero
> ------------------------------------------
>
>                 Key: VELOCITY-850
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-850
>             Project: Velocity
>          Issue Type: Bug
>          Components: Engine
>    Affects Versions: 1.7
>         Environment: all
>            Reporter: Beat Durrer
>            Priority: Minor
>              Labels: documentation, easyfix
>
> The base class ResourceLoader handles the loading of the modificationCheckInterval property. However, if the property is not present, or not of the correct type (long), it changes the default to zero.
> This issue is amplified by the fact, that ExtendedProperties#getLong(name,default) does not cast Integers to Long (But it accepts a String property).
> The type requirements should either be documented or the code should be improved to support casts from Integer to Long. Neglecting this actually disables cache refreshing and is hard to find for users.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org