You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sven Meier (JIRA)" <ji...@apache.org> on 2016/04/07 09:24:25 UTC
[jira] [Resolved] (WICKET-6139) AjaxButton forces rendering
type="button"
[ https://issues.apache.org/jira/browse/WICKET-6139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sven Meier resolved WICKET-6139.
--------------------------------
Resolution: Fixed
Fix Version/s: 8.0.0-M1
7.3.0
It seems tampering with the button type was a bad idea after all: it is left untouched now.
When JavaScript is disabled, the normal HTTP request will be logged as a warning, effectively ignoring the click as before. Users can just use type="button" in their markup if they want to prevent the superfluous request in this case.
> AjaxButton forces rendering type="button"
> ------------------------------------------
>
> Key: WICKET-6139
> URL: https://issues.apache.org/jira/browse/WICKET-6139
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 7.0.0-M2
> Reporter: Roland Foerther
> Assignee: Sven Meier
> Priority: Minor
> Fix For: 7.3.0, 8.0.0-M1
>
>
> Since WICKET-5594 AjaxButton forces rendering type="button". I understand, that this is the desired behavior if JavaScript is disabled. On the other hand it disables the browser behavior "submit form on enter" when JavaScript is enabled. I can't see any problem on using type="submit" in conjunction with AjaxButton, since the designated Methods onSubmit(AjaxRequestTarget target, Form<?> form), onAfterSubmit(AjaxRequestTarget target, Form<?> form) and onError(AjaxRequestTarget target, Form<?> form) will be called when pressing enter.
> The new behavior affects a lot of forms in our wicket applications we are currently porting from Wicket 6 to 7.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)