You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/12/14 09:15:32 UTC
[GitHub] [echarts] robin-gerling commented on pull request #16825: Changed calculated label gap to be passed from top
robin-gerling commented on PR #16825:
URL: https://github.com/apache/echarts/pull/16825#issuecomment-1350694888
Hey @Ovilia, hey @100pah,
I will continue resolving the comments of this PR, but I have a few questions.
I have read through the comments of PR https://github.com/apache/echarts/pull/12236 and this PR and wonder why outsideStart and outsideEnd were added. Was this requested by you?
To me, outsideStart doesn't make sense since the x-axis name is left of the y-axis and the y-axis name is below the x-axis (when using start) but I cannot see how to access the LabelUnionRect of the other axis (the axes are also created sequentially, which is why we cannot access the second axis from the first during the creation of the first axis). Do I miss something regarding this problem?
For outsideEnd, the logic gets quite complex since there should be a differentiation between positive/negative rotation of the labels, category vs value axis-type (since e.g. the category labels are centred between axis ticks while labels for the value type are centred below the ticks). Also in case the y-axis is not at the left but on the right, the same problem as for outsideStart arises.
Based on those findings I would remove outsideStart and outsideEnd from the PR. Do you agree with removing it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org