[jira] Commented: (SOLR-1088) newSearcher(String name, boolean readOnly) is broken

["Mark Miller (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705308#action_12705308 ] 

Mark Miller commented on SOLR-1088:
-----------------------------------

I was leaning towards keeping it, because its no real overhead and why not have the option. Looking further though, even newSearcher(String name) is only used internally by DirectUpdateHandler, which is deprecated. I guess I would vote to just pull it before it becomes part of a release. If a use case comes up, its easy enough to add in the future.

Having said that, I wouldn't argue if anyone thought it was better to keep it and fix - the above patch does fix it.

> newSearcher(String name, boolean readOnly) is broken
> ----------------------------------------------------
>
>                 Key: SOLR-1088
>                 URL: https://issues.apache.org/jira/browse/SOLR-1088
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>            Assignee: Mark Miller
>             Fix For: 1.4
>
>         Attachments: SOLR-1088.patch
>
>
> Noted on the mailing list while investigating something semi-related, the method SolrCore.newSearcher(String name, boolean readOnly) doesn't work as advertised (the readOnly option is completely ignored)
> the method isn't used anywhere in Solr (that i could find) but it might be used by clients ... we should deal with this in some way prior to the 1.4 release (either fix; fix & deprecate; or document problem and deprecate)
> http://www.nabble.com/Re%3A-Lucene-sync-bottleneck--p22237748.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.