[jira] [Commented] (ACE-191) Provision Glassfish servers

["Marcel Offermans (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACE-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134784#comment-13134784 ] 

Marcel Offermans commented on ACE-191:
--------------------------------------

Three comments after reviewing this:

Firstly, the ServerType (enum) class seems to be missing from this patch.

Secondly, right now, you more or less "hardcode" the server types by explicitly creating an enum for them. That means that every time we want to add a new server type, we need to modify this code. I think we should try to make the server types configurable.

Finally, there is a hardcoded link to an S3 file in the codebase right now. I understand that's where you now "parked" the GF zip file, but I think we should not hardcode such links. By solving remark #2 I'm hoping this one goes away as well.

WDYT?
                
> Provision Glassfish servers
> ---------------------------
>
>                 Key: ACE-191
>                 URL: https://issues.apache.org/jira/browse/ACE-191
>             Project: Ace
>          Issue Type: New Feature
>            Reporter: Paul Bakker
>            Assignee: Marcel Offermans
>         Attachments: glassfish-aws.patch
>
>
> It should be possible to provision a Glassfish server instead of a pure Felix instance. Glassfish contains Felix and in recent versions you can directly deploy OSGI bundles as you would do in a normal OSGI container. There are some extra features however; for example you can use EJB, JPA and CDI from bundles and use the WAB as deployment type besides normal bundles. In the future we can also build towards clustering support on top of GF.
> I fixed this by creating a new Ace launcher specifically for Glassfish. It downloads and unzips GF, changes it's configuration files and installs the Ace Management Agent. GF is started using asadmin after that. Besides this I changed the Amazon Node Laucher. You can now configure a serverType to either DEFAULT or GLASSFISH. When the type is GLASSFISH it changes the startup script to download and use the new Glassfish launcher. 
> At this moment Glassfish is downloaded from a S3 bucket that I created because the official download server is extremely slow. We have to come up with something better however.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira