You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/21 14:12:22 UTC
[GitHub] [doris] liutang123 opened a new pull request, #15259: [Pipeline] Fix PipScannerContext::can_finish return wrong status
liutang123 opened a new pull request, #15259:
URL: https://github.com/apache/doris/pull/15259
# Proposed changes
Issue Number: close #xxx
## Problem summary
Now in `ScannerContext::push_back_scanner_and_reschedule`, `_num_running_scanners--` is before `_num_scheduling_ctx++`.
In`PipScannerContext::can_finish`, we check `_num_running_scanners == 0 && _num_scheduling_ctx == 0` without obtaining `_transfer_lock`.
In follow case, `PipScannerContext::can_finish` will return wrong result.
1. _num_running_scanners--
2. Check _num_running_scanners == 0 && _num_scheduling_ctx == 0` return true.
3. _num_scheduling_ctx++
So, we can set `_num_running_scanners--` after `_num_scheduling_ctx++`.
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
5. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
6. Does it need to update dependencies:
- [ ] Yes
- [ ] No
7. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15259: [Pipeline] Fix PipScannerContext::can_finish return wrong status
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15259:
URL: https://github.com/apache/doris/pull/15259#issuecomment-1363761728
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15259: [Pipeline] Fix PipScannerContext::can_finish return wrong status
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15259:
URL: https://github.com/apache/doris/pull/15259#issuecomment-1363750913
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15259: [Pipeline] Fix PipScannerContext::can_finish return wrong status
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15259:
URL: https://github.com/apache/doris/pull/15259#issuecomment-1361363940
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15259: [Pipeline] Fix PipScannerContext::can_finish return wrong status
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15259:
URL: https://github.com/apache/doris/pull/15259#issuecomment-1365134000
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15259: [Pipeline] Fix PipScannerContext::can_finish return wrong status
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15259:
URL: https://github.com/apache/doris/pull/15259#issuecomment-1364652693
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15259: [Pipeline] Fix PipScannerContext::can_finish return wrong status
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15259:
URL: https://github.com/apache/doris/pull/15259#issuecomment-1367949721
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15259: [Pipeline] Fix PipScannerContext::can_finish return wrong status
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15259:
URL: https://github.com/apache/doris/pull/15259#issuecomment-1371698915
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15259: [Pipeline] Fix PipScannerContext::can_finish return wrong status
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15259:
URL: https://github.com/apache/doris/pull/15259#issuecomment-1371698814
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15259: [Pipeline] Fix PipScannerContext::can_finish return wrong status
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15259:
URL: https://github.com/apache/doris/pull/15259#issuecomment-1361680226
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.83 seconds
load time: 634 seconds
storage size: 17122433872 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221221170643_clickbench_pr_66606.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #15259: [Pipeline] Fix PipScannerContext::can_finish return wrong status
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #15259:
URL: https://github.com/apache/doris/pull/15259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15259: [Pipeline] Fix PipScannerContext::can_finish return wrong status
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15259:
URL: https://github.com/apache/doris/pull/15259#issuecomment-1365749557
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15259: [Pipeline] Fix PipScannerContext::can_finish return wrong status
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15259:
URL: https://github.com/apache/doris/pull/15259#issuecomment-1367712584
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org