[GitHub] [tvm] lhutton1 commented on pull request #11519: [TFLite] Support quantized GREATER op in TFLite frontend

[GitBox <gi...@apache.org>]

lhutton1 commented on PR #11519:
URL: https://github.com/apache/tvm/pull/11519#issuecomment-1162984925

   If I inspect the Relay graph(s) that is tested when running `_test_forward_elemwise_quantized(_test_greater, True)`, it seems as though it doesn't get quantized in any way e.g.
   ```
   def @main(%inq_0: Tensor[(3, 6), float32] /* ty=Tensor[(3, 6), float32] */, %inq_1: Tensor[(3, 6), float32] /* ty=Tensor[(3, 6), float32] */, output_tensor_names=["Greater"]) -> Tensor[(3, 6), bool] {
     greater(%inq_0, %inq_1) /* ty=Tensor[(3, 6), bool] */
   }
   ```
   So then it seems we're still only testing the float32 implementation of the operator? For a quantized operator I'd expect int/uint inputs being passed to the `greater` op - maybe I missed something?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org