You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "heyroman (via GitHub)" <gi...@apache.org> on 2023/04/12 13:19:36 UTC
[GitHub] [superset] heyroman opened a new issue, #23661: Unescaped timestamps in a generated query when using time column filter with Vertica
heyroman opened a new issue, #23661:
URL: https://github.com/apache/superset/issues/23661
Superset generates invalid datetime filters that look like this
```
WHERE "timestamp_column" >= 2023-04-05 00:00:00.000000
AND "timestamp_column" < 2023-04-12 00:00:00.000000
```
The values it inserts are unquoted which leads to query failing a syntax check.
#### How to reproduce the bug
1. Use a connection to Vertica
2. Create any chart with a time column
3. Try to add a filter on this time column (for example, "last week")
### Expected results
The generated query has a filter formatted as
```
WHERE "timestamp_column" >= '2023-04-05 00:00:00.000000'
AND "timestamp_column" < '2023-04-12 00:00:00.000000'
```
### Actual results
```
WHERE "timestamp_column" >= 2023-04-05 00:00:00.000000
AND "timestamp_column" < 2023-04-12 00:00:00.000000
```
#### Screenshots
### Environment
I'm trying superset out so I run it with docker-compose. Currently this issue is reproduced with `latest-dev` and `master` tags.
I have not made any changes to the configuration apart from adding 1 feature flag.
- any feature flags active: [ALERT_REPORTS, TAGGING_SYSTEM]
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [.] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [.] I have reproduced the issue with at least the latest released version of superset.
- [.] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] heyroman commented on issue #23661: Unescaped timestamps in a generated query when using time column filter with Vertica
Posted by "heyroman (via GitHub)" <gi...@apache.org>.
heyroman commented on issue #23661:
URL: https://github.com/apache/superset/issues/23661#issuecomment-1505300311
The issue is not reproduced with images tagged with `2.1.0` and `2.1.0-dev`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Unquoted datetime values in a generated query when using time column filter with Vertica [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #23661:
URL: https://github.com/apache/superset/issues/23661#issuecomment-1962102615
This is likely fixed by now, but is pretty out of date if not. If people are still encountering this in current versions (3.x) please open a new Issue or a PR to address the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Unquoted datetime values in a generated query when using time column filter with Vertica [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #23661: Unquoted datetime values in a generated query when using time column filter with Vertica
URL: https://github.com/apache/superset/issues/23661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org