[GitHub] [thrift] emmenlau opened a new pull request #2436: lib/cpp/test/ToStringTest.cpp: Disabled locale-based tests on Windows

[GitBox <gi...@apache.org>]

emmenlau opened a new pull request #2436:
URL: https://github.com/apache/thrift/pull/2436


   This PR disables the locale-based tests for string conversion on Windows, due to problems in the Thrift CI on AppVeyor.
   
   - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  Not required for the trivial change.
   - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] emmenlau merged pull request #2436: lib/cpp/test/ToStringTest.cpp: Disabled locale-based tests on Windows

[GitBox <gi...@apache.org>]

emmenlau merged pull request #2436:
URL: https://github.com/apache/thrift/pull/2436


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org