You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@climate.apache.org by OCWJenkins <gi...@git.apache.org> on 2014/07/01 18:37:31 UTC
[GitHub] climate pull request: CLIMATE-241 - Update plotter.py docstring fo...
GitHub user OCWJenkins opened a pull request:
https://github.com/apache/climate/pull/83
CLIMATE-241 - Update plotter.py docstring formatting
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MJJoyce/climate CLIMATE-241
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/83.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #83
----
commit e867441ce3b04a5e95ee3c059ca501abd0d0ac1b
Author: Michael Joyce <jo...@apache.org>
Date: 2014-07-01T15:45:22Z
CLIMATE-241 - Update draw_taylor_diagram docstring format
commit a0fab68916e4178e732a3b455d9f9bc54156c0aa
Author: Michael Joyce <jo...@apache.org>
Date: 2014-07-01T15:58:06Z
CLIMATE-241 - Update draw_subregions docstring format
commit 3ac4438e6e172dd9cacee714d61507b49c0de600
Author: Michael Joyce <jo...@apache.org>
Date: 2014-07-01T16:11:14Z
CLIMATE-241 - Update draw_time_series docstring format
commit 007bc9a7d05a91938d06bc3ee9e20f76b04918cb
Author: Michael Joyce <jo...@apache.org>
Date: 2014-07-01T16:28:05Z
CLIMATE-241 - Update draw_contour_map docstring format
commit e5ca8698839f399d376d62038554649bd3be7329
Author: Michael Joyce <jo...@apache.org>
Date: 2014-07-01T16:35:44Z
CLIMATE-241 - Update draw_portrait_diagram docstring format
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-241 - Update plotter.py docstring fo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/climate/pull/83
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-241 - Update plotter.py docstring fo...
Posted by MJJoyce <gi...@git.apache.org>.
Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/83#issuecomment-47775552
Cheers @agoodm!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-241 - Update plotter.py docstring fo...
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/83#issuecomment-47679755
If @agoodm could take a look and make sure all of this reads alright I would be super appreciative :)
Also, @agoodm, I noticed that the subregion function specifies that it needs "subregion objects." Do we document what exactly that means somewhere or was there a different assumption being made when this was done?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-241 - Update plotter.py docstring fo...
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/83#issuecomment-47679492
Merged build finished. Test Passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-241 - Update plotter.py docstring fo...
Posted by agoodm <gi...@git.apache.org>.
Github user agoodm commented on the pull request:
https://github.com/apache/climate/pull/83#issuecomment-47701572
@MJJoyce
:+1: To the actual changes. I actually liked that you clarified a few of the parameters by adding links to relative matplotlib and basemap documentation too.
Regarding the ```draw_subregions``` function, the "subRegion" object refers to the class inside the ```rcmet/src/main/python/rcmes/classes.py``` module, which I believe is what we used for subregion parsing in the past. The equivalent to this in the refactoring branch is probably ```ocw.dataset.Bounds```.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-241 - Update plotter.py docstring fo...
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/83#issuecomment-47679330
Merged build started. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-241 - Update plotter.py docstring fo...
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/83#issuecomment-47679323
Merged build started. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-241 - Update plotter.py docstring fo...
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/83#issuecomment-47679349
Merged build finished. Test Passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-241 - Update plotter.py docstring fo...
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/83#issuecomment-47679317
Merged build triggered. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-241 - Update plotter.py docstring fo...
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/83#issuecomment-47679311
Merged build triggered. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-241 - Update plotter.py docstring fo...
Posted by MJJoyce <gi...@git.apache.org>.
Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/83#issuecomment-47679932
If @agoodm could take a look and make sure all of this reads alright I would be super appreciative :)
Also, @agoodm, I noticed that the subregion function specifies that it needs "subregion objects." Do we document what exactly that means somewhere or was there a different assumption being made when this was done?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---