[jira] [Comment Edited] (AIRFLOW-6210) Reuse SQLAlchemy session in ti_deps

["Ash Berlin-Taylor (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16992976#comment-16992976 ] 

Ash Berlin-Taylor edited comment on AIRFLOW-6210 at 12/10/19 9:46 PM:
----------------------------------------------------------------------

This didn't show up at all as a slow spot in my recent profiling work, so while it might be "better" I doubt it will have any impact on performance. (I was testing with a dag with 40 tasks and up to 100 active dag runs, and the session "checkout" didn't come anywhere close to being a bottle neck)


was (Author: ashb):
This didn't show up at all as a slow spot in my recent profiling work, so while it might be "better" I doubt it will have any impact on performance.

> Reuse SQLAlchemy session in ti_deps
> -----------------------------------
>
>                 Key: AIRFLOW-6210
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6210
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: core, scheduler
>    Affects Versions: 1.10.6
>            Reporter: Kamil Bregula
>            Priority: Major
>
> This generates unnecessary overhead and it is good practice to use the session again if possible. These functions are performed in a loop, so it can be a bigger issues in some cases.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)