[GitHub] [cloudstack] harikrishna-patnala commented on issue #3969: Snapshot deletion issues

[GitBox <gi...@apache.org>]

harikrishna-patnala commented on issue #3969: Snapshot deletion issues
URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-608490677
 
 
   Have seen couple of issues when handling deletesnapshot for snapshots backed up only in primary storage and snapshots backed up in secondary storage. I have made a fix for that but unable to push the changes due to some access issues. I'll update the PR once I resolve my access issue.0
   
   Following are the test cases I covered after the fix is made
   1. Create data volumes vol1 and vol2
   2. Set global parameter snapshots.backup.to.secondary = true
   3. Create snapshot snap1vol1 from vol1
   4. Set global parameter snapshots.backup.to.secondary = false
   5. Create snapshot snap2vol2 from vol2 
   6. Create snapshot snap3vol1 form vol1
   7. Delete snap2vol2 // This is deletion of snapshot which is created only in primary and no entries in snapshot_store_ref table against store_role ‘Image’
   8. Delete snap3vol1 // This is deletion of snapshot which is created only in primary but MS can get a snapshot_store_ref entry against store_role ‘Image’ with id of vol1 because snap1vol1 are created in both primary and secondary storage from vol1
   9. Delete snap1vol1 // This is deletion of snapshot which is created both in primary and secondary
   
   Attached the patch if someone can add it on behalf of me.
   [0001-Fix-deletesnapshot-worflow-to-handle-both-snapshots-.patch.zip](https://github.com/apache/cloudstack/files/4428067/0001-Fix-deletesnapshot-worflow-to-handle-both-snapshots-.patch.zip)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services