You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Uma Maheswara Rao G (Created) (JIRA)" <ji...@apache.org> on 2012/01/07 19:09:41 UTC
[jira] [Created] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
BackupNode stop can not close proxy connections because it is not a proxy instance.
-----------------------------------------------------------------------------------
Key: HDFS-2768
URL: https://issues.apache.org/jira/browse/HDFS-2768
Project: Hadoop HDFS
Issue Type: Bug
Components: name-node
Affects Versions: 0.24.0
Reporter: Uma Maheswara Rao G
Assignee: Uma Maheswara Rao G
Observe this from BackupNode tests:
java.lang.IllegalArgumentException: not a proxy instance
at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at junit.framework.TestCase.runTest(TestCase.java:168)
at junit.framework.TestCase.runBare(TestCase.java:134)
at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186079#comment-13186079 ]
Uma Maheswara Rao G commented on HDFS-2768:
-------------------------------------------
@Eli, Updated the patch. In this patch, I just moved the namenode connection close section to DFSUtil and reused every where. This patch will address your comment.
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-2768.patch, HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HDFS-2768:
--------------------------------------
Attachment: HDFS-2768.patch
Problem here is EditLogBackupStream is not able to close the proxy.
Corrected in this patch.No tests included, Observed the above logs in TestBackupNode. No error logs with this patch.
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187329#comment-13187329 ]
Uma Maheswara Rao G commented on HDFS-2768:
-------------------------------------------
Hi Eli, Thanks for the review.
The classes like, ClinetProtocol, NamenodeProtocol..etc are not closeables. So, we can't call directly IOUtils.cleanUp. Anyway we need to add the closeable checks.
You mean, just need to remove, RPC.stopProxy invocation? and also no need to re-factor DFSClient#closeConnectionToNamenode to DFSUtil? ( this is re-factored because, i have seen similar piece of code in ConfiguredFailoverProxyProvider also, So, in future we can use this api to close the connection)
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-2768.patch, HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186087#comment-13186087 ]
Hadoop QA commented on HDFS-2768:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12510559/HDFS-2768.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated 21 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
-1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings).
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1777//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1777//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1777//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1777//console
This message is automatically generated.
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-2768.patch, HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182635#comment-13182635 ]
Uma Maheswara Rao G commented on HDFS-2768:
-------------------------------------------
seems Test failures are unrelated to this path. They are due to time outs of TestBalancer. These tests are passing for me.
{quote}
Running org.apache.hadoop.hdfs.server.balancer.TestBalancer
Running org.apache.hadoop.hdfs.server.namenode.TestNameNodeMXBean
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.221 sec <<< FAILURE!
{quote}
findbugs, javadocs also unrelated.
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Eli Collins (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185129#comment-13185129 ]
Eli Collins commented on HDFS-2768:
-----------------------------------
The type of backupNode and namenode should be NamenodeProtocol not NamenodeProtocolTranslatorPB right? Otherwise looks great.
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189412#comment-13189412 ]
Hudson commented on HDFS-2768:
------------------------------
Integrated in Hadoop-Common-trunk-Commit #1557 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1557/])
HDFS-2768. BackupNode stop can not close proxy connections because it is not a proxy instance. Contributed by Uma Maheswara Rao G.
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1233584
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogBackupOutputStream.java
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 0.24.0
>
> Attachments: HDFS-2768.patch, HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189414#comment-13189414 ]
Hudson commented on HDFS-2768:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #1630 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1630/])
HDFS-2768. BackupNode stop can not close proxy connections because it is not a proxy instance. Contributed by Uma Maheswara Rao G.
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1233584
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogBackupOutputStream.java
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 0.24.0
>
> Attachments: HDFS-2768.patch, HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Eli Collins (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-2768:
------------------------------
Resolution: Fixed
Target Version/s: 0.24.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I've committed this. Thanks Uma.
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-2768.patch, HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189767#comment-13189767 ]
Hudson commented on HDFS-2768:
------------------------------
Integrated in Hadoop-Hdfs-trunk #931 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/931/])
HDFS-2768. BackupNode stop can not close proxy connections because it is not a proxy instance. Contributed by Uma Maheswara Rao G.
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1233584
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogBackupOutputStream.java
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 0.24.0
>
> Attachments: HDFS-2768.patch, HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185408#comment-13185408 ]
Uma Maheswara Rao G commented on HDFS-2768:
-------------------------------------------
Eli, I think in BPOfferSevice also we used DatanodeProtocolClientSideTranslatorPB directly instead of DatanodeProtocol. In that class many places already specialized to DatanodeProtocolClientSideTranslatorPB.
Do you think we can change that as well to DatanodeProtocol along with it ? (or) is it ok, as **TranslatorPBs are mainly delegating calls to actual proxies?
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Eli Collins (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-2768:
------------------------------
Target Version/s: (was: 0.24.0)
Fix Version/s: 0.24.0
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 0.24.0
>
> Attachments: HDFS-2768.patch, HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Eli Collins (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187314#comment-13187314 ]
Eli Collins commented on HDFS-2768:
-----------------------------------
Hi Uma,
Doesn't seem like classes like BPOfferService need to call DFSUtil.closeConnectionToNamenode, since all the protocol references refer to underling *PB classes that will stop the proxy on close, ie just calling IOUtils#cleanup as they do currently is sufficient (don't need to close and stopProxy). Ie howabout your latest patch but instead of factoring closeConnectionToNamenode out of DFSClient keeping that as is (it DFSClient we don't always have a PB class) and just using calls to IOUtils#cleanup instead?
Thanks,
Eli
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-2768.patch, HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189449#comment-13189449 ]
Hudson commented on HDFS-2768:
------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1575 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1575/])
HDFS-2768. BackupNode stop can not close proxy connections because it is not a proxy instance. Contributed by Uma Maheswara Rao G.
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1233584
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogBackupOutputStream.java
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 0.24.0
>
> Attachments: HDFS-2768.patch, HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182233#comment-13182233 ]
Hadoop QA commented on HDFS-2768:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12509846/HDFS-2768.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated 21 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
-1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings).
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
org.apache.hadoop.hdfs.server.namenode.TestNameNodeMXBean
org.apache.hadoop.hdfs.server.namenode.TestEditLogFileOutputStream
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1767//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1767//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1767//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1767//console
This message is automatically generated.
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Uma Maheswara Rao G (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G reopened HDFS-2768:
---------------------------------------
Seems this changes has been reverted with HA merge.
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 2.0.0
>
> Attachments: HDFS-2768.patch, HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184283#comment-13184283 ]
Uma Maheswara Rao G commented on HDFS-2768:
-------------------------------------------
Would someone please take a look on this patch.?
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-2768:
-----------------------------------------
Fix Version/s: 0.23.3
I have merged this to 0.23.
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 0.24.0, 0.23.3
>
> Attachments: HDFS-2768.patch, HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186077#comment-13186077 ]
Uma Maheswara Rao G commented on HDFS-2768:
-------------------------------------------
@Brandon, Thanks for looking this issue. Please take a look at my previous comment.
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Uma Maheswara Rao G (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G resolved HDFS-2768.
---------------------------------------
Resolution: Fixed
Seems, this was already fixed in trunk as part of HADOOP-8202
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 2.0.0
>
> Attachments: HDFS-2768.patch, HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HDFS-2768:
--------------------------------------
Attachment: HDFS-2768.patch
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-2768.patch, HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186095#comment-13186095 ]
Uma Maheswara Rao G commented on HDFS-2768:
-------------------------------------------
Warnings are not related to this patch!
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-2768.patch, HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HDFS-2768:
--------------------------------------
Status: Open (was: Patch Available)
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-2768.patch, HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185400#comment-13185400 ]
Uma Maheswara Rao G commented on HDFS-2768:
-------------------------------------------
Thanks a lot Eli, for the review.
Here NamenodeProtocolTranslatorPB are delegating the calls to it and actual proxy maintained in NamenodeProtocolTranslatorPB class. And also NamenodeProtocol is not a closeable.
infact, the otherway could be to add the instanceOf closeable checks in close and keep the NamenodeProtocol as it is.
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HDFS-2768:
--------------------------------------
Status: Patch Available (was: Open)
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189797#comment-13189797 ]
Hudson commented on HDFS-2768:
------------------------------
Integrated in Hadoop-Mapreduce-trunk #964 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/964/])
HDFS-2768. BackupNode stop can not close proxy connections because it is not a proxy instance. Contributed by Uma Maheswara Rao G.
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1233584
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogBackupOutputStream.java
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 0.24.0
>
> Attachments: HDFS-2768.patch, HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HDFS-2768:
--------------------------------------
Status: Patch Available (was: Open)
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-2768.patch, HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Brandon Li (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185937#comment-13185937 ]
Brandon Li commented on HDFS-2768:
----------------------------------
Another way to fix this is to check if the proxy is closeable in RPC.stopProxy(). If it is, just close it. This way we just need to fix the problem in one place instead of multiple ones, e.g., BackupNode, EditLogOutputStream and etc.
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Eli Collins (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189393#comment-13189393 ]
Eli Collins commented on HDFS-2768:
-----------------------------------
I see what you mean. Apologies for the confusion. I'm +1 on your 1st patch (agree test failures are unrelated). We can do refactoring in a separate change if necessary, seems like the PB classes are doing too much (handling both the PB proxying and the closing).
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-2768.patch, HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2768) BackupNode stop can not close proxy
connections because it is not a proxy instance.
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189517#comment-13189517 ]
Uma Maheswara Rao G commented on HDFS-2768:
-------------------------------------------
Thanks a lot Eli for the review!
> BackupNode stop can not close proxy connections because it is not a proxy instance.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-2768
> URL: https://issues.apache.org/jira/browse/HDFS-2768
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 0.24.0
>
> Attachments: HDFS-2768.patch, HDFS-2768.patch
>
>
> Observe this from BackupNode tests:
> java.lang.IllegalArgumentException: not a proxy instance
> at java.lang.reflect.Proxy.getInvocationHandler(Unknown Source)
> at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:557)
> at org.apache.hadoop.hdfs.server.namenode.BackupNode.stop(BackupNode.java:194)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testCheckpoint(TestBackupNode.java:355)
> at org.apache.hadoop.hdfs.server.namenode.TestBackupNode.testBackupNode(TestBackupNode.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira