You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "mapleFU (via GitHub)" <gi...@apache.org> on 2023/04/02 15:36:51 UTC

[GitHub] [arrow] mapleFU commented on pull request #34511: GH-29105: [C++][Parquet] Relax schema checking when writing using StreamWriter

mapleFU commented on PR #34511:
URL: https://github.com/apache/arrow/pull/34511#issuecomment-1493374263

   Hi @omrimallis . Personally I'm ok for this patch. If you want, you can encapsulate in in common header for `stream_reader.cc` and `stream_writer.cc`. My view is that, for reader, we need to support some backward-capability rules. However, for writer, I don't think we should keep the rule, because writer schema is created by user, and user can deduce specifict convert types.
   
   If you want, I think just put it to stream_reader and stream_writer is ok


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org