You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "wyxxxcat (via GitHub)" <gi...@apache.org> on 2026/05/28 08:51:21 UTC
[PR] [chore](cloud) Support dynamic recycler instance filter config [doris]
wyxxxcat opened a new pull request, #63822:
URL: https://github.com/apache/doris/pull/63822
### What problem does this PR solve?
Read recycler whitelist and blacklist directly from config when scanning
instances, so runtime config updates can affect filtering without restart.
Add a unit test for dynamic filter changes.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cloud) Support dynamic recycler instance filter config [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou merged PR #63822:
URL: https://github.com/apache/doris/pull/63822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cloud) Support dynamic recycler instance filter config [doris]
Posted by "wyxxxcat (via GitHub)" <gi...@apache.org>.
wyxxxcat commented on PR #63822:
URL: https://github.com/apache/doris/pull/63822#issuecomment-4562532351
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cloud) Support dynamic recycler instance filter config [doris]
Posted by "wyxxxcat (via GitHub)" <gi...@apache.org>.
wyxxxcat commented on PR #63822:
URL: https://github.com/apache/doris/pull/63822#issuecomment-4562297988
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cloud) Support dynamic recycler instance filter config [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #63822:
URL: https://github.com/apache/doris/pull/63822#discussion_r3331563192
##########
cloud/src/common/configbase.cpp:
##########
@@ -504,17 +505,30 @@ std::pair<bool, std::string> update_config(const std::string& configs, bool pers
std::unordered_map<std::string, std::string> conf_map;
std::istringstream ss(configs);
std::string conf;
+ std::string key;
+ std::string val;
+ auto add_config = [&]() {
+ if (!key.empty()) {
Review Comment:
This now silently drops malformed entries whose key is empty. For example, `update_config("recycle_blacklist=a,=b", false, "")` reaches `add_config()` with an empty trimmed key for the second entry, skips it because of this guard, and returns success after applying only `recycle_blacklist=a`. Before this parser rewrite the same empty key was inserted into the map and `set_config` failed with `config field= not exists`, so callers could detect the bad request. Please reject empty keys instead of ignoring them, including after trimming, so the update API does not report success for partially malformed config strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cloud) Support dynamic recycler instance filter config [doris]
Posted by "wyxxxcat (via GitHub)" <gi...@apache.org>.
wyxxxcat commented on PR #63822:
URL: https://github.com/apache/doris/pull/63822#issuecomment-4589363540
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cloud) Support dynamic recycler instance filter config [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63822:
URL: https://github.com/apache/doris/pull/63822#issuecomment-4562297458
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cloud) Support dynamic recycler instance filter config [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63822:
URL: https://github.com/apache/doris/pull/63822#issuecomment-4589354155
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cloud) Support dynamic recycler instance filter config [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #63822:
URL: https://github.com/apache/doris/pull/63822#discussion_r3316540725
##########
cloud/src/recycler/recycler.cpp:
##########
@@ -97,6 +97,15 @@ void sleep_for_packed_file_retry() {
std::this_thread::sleep_for(std::chrono::milliseconds(packed_file_retry_sleep_ms()));
}
+bool filter_out_instance(const std::string& instance_id) {
Review Comment:
This direct read does not make the filter dynamically configurable in production. `recycle_whitelist` and `recycle_blacklist` are still declared as `CONF_Strings` in `cloud/src/common/config.h`, so `config::set_config` rejects them as immutable, and `do_set_config` only handles scalar types plus `std::string`, not `std::vector<std::string>`. The new test mutates the globals directly, but the supported runtime update path cannot do that, so recycler filtering still cannot be changed without restart. Please make these configs genuinely mutable through the config API (with a safe read/update mechanism for the vectors) and test that path rather than direct assignment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cloud) Support dynamic recycler instance filter config [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63822:
URL: https://github.com/apache/doris/pull/63822#issuecomment-4563120789
# Cloud UT Coverage Report
Increment line coverage `100.00% (27/27)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/236038efe71026fde0d76a13ef24598909e3f257_236038efe71026fde0d76a13ef24598909e3f257_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/236038efe71026fde0d76a13ef24598909e3f257_236038efe71026fde0d76a13ef24598909e3f257_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 78.08% (1856/2377) |
| Line Coverage | 64.56% (33373/51691) |
| Region Coverage | 65.27% (16560/25373) |
| Branch Coverage | 55.79% (8858/15878) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cloud) Support dynamic recycler instance filter config [doris]
Posted by "wyxxxcat (via GitHub)" <gi...@apache.org>.
wyxxxcat commented on PR #63822:
URL: https://github.com/apache/doris/pull/63822#issuecomment-4562297252
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org