You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2020/03/16 22:22:41 UTC
[kudu-CR] build-and-test.sh: address follow-up feedback from Andrew
Hello Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/15452
to review the following change.
Change subject: build-and-test.sh: address follow-up feedback from Andrew
......................................................................
build-and-test.sh: address follow-up feedback from Andrew
Change-Id: I8e73381bc853f05d6b3400ebadad5a280b5f1294
---
M build-support/jenkins/build-and-test.sh
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/15452/1
--
To view, visit http://gerrit.cloudera.org:8080/15452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e73381bc853f05d6b3400ebadad5a280b5f1294
Gerrit-Change-Number: 15452
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] build-and-test.sh: address follow-up feedback from Andrew
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15452 )
Change subject: build-and-test.sh: address follow-up feedback from Andrew
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e73381bc853f05d6b3400ebadad5a280b5f1294
Gerrit-Change-Number: 15452
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Mar 2020 22:58:55 +0000
Gerrit-HasComments: No
[kudu-CR] build-and-test.sh: address follow-up feedback from Andrew
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15452 )
Change subject: build-and-test.sh: address follow-up feedback from Andrew
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/15452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I8e73381bc853f05d6b3400ebadad5a280b5f1294
Gerrit-Change-Number: 15452
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] build-and-test.sh: address follow-up feedback from Andrew
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15452 )
Change subject: build-and-test.sh: address follow-up feedback from Andrew
......................................................................
Patch Set 1: Code-Review+2
Thanks for addressing this!
--
To view, visit http://gerrit.cloudera.org:8080/15452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e73381bc853f05d6b3400ebadad5a280b5f1294
Gerrit-Change-Number: 15452
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Mar 2020 22:28:57 +0000
Gerrit-HasComments: No
[kudu-CR] build-and-test.sh: address follow-up feedback from Andrew
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15452 )
Change subject: build-and-test.sh: address follow-up feedback from Andrew
......................................................................
Patch Set 1: Verified+1
Overriding Jenkins, unrelated test failures.
--
To view, visit http://gerrit.cloudera.org:8080/15452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e73381bc853f05d6b3400ebadad5a280b5f1294
Gerrit-Change-Number: 15452
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Mar 2020 23:05:46 +0000
Gerrit-HasComments: No
[kudu-CR] build-and-test.sh: address follow-up feedback from Andrew
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15452 )
Change subject: build-and-test.sh: address follow-up feedback from Andrew
......................................................................
build-and-test.sh: address follow-up feedback from Andrew
Change-Id: I8e73381bc853f05d6b3400ebadad5a280b5f1294
Reviewed-on: http://gerrit.cloudera.org:8080/15452
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M build-support/jenkins/build-and-test.sh
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Grant Henke: Looks good to me, approved
Adar Dembo: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e73381bc853f05d6b3400ebadad5a280b5f1294
Gerrit-Change-Number: 15452
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>