You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/12 04:51:21 UTC
[GitHub] [tvm] masahi opened a new pull request #7451: [VM] Move param bind to OptimizeModule
masahi opened a new pull request #7451:
URL: https://github.com/apache/tvm/pull/7451
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #7451: [VM] Move param bind to OptimizeModule
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #7451:
URL: https://github.com/apache/tvm/pull/7451#issuecomment-778556074
@icemelon9 ready to merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi edited a comment on pull request #7451: [VM] Move param bind to OptimizeModule
Posted by GitBox <gi...@apache.org>.
masahi edited a comment on pull request #7451:
URL: https://github.com/apache/tvm/pull/7451#issuecomment-778456108
@icemelon9 Add a test to verify that all params are bound in the output of `vm.optimize()`. This can be checked by counting the number of free vars in the main body. I think this is neat!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #7451: [VM] Move param bind to OptimizeModule
Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7451:
URL: https://github.com/apache/tvm/pull/7451#issuecomment-778324260
This makes a lot more sense to me, thanks Masa.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #7451: [VM] Move param bind to OptimizeModule
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #7451:
URL: https://github.com/apache/tvm/pull/7451#issuecomment-778456108
@icemelon9 Add a test to verify that all params are bound in the output of `vm.optimize()`. This can be checked by counting the number of free vars in the main body.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #7451: [VM] Move param bind to OptimizeModule
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #7451:
URL: https://github.com/apache/tvm/pull/7451
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] icemelon9 commented on a change in pull request #7451: [VM] Move param bind to OptimizeModule
Posted by GitBox <gi...@apache.org>.
icemelon9 commented on a change in pull request #7451:
URL: https://github.com/apache/tvm/pull/7451#discussion_r575625336
##########
File path: src/relay/backend/vm/compiler.cc
##########
@@ -1007,6 +998,15 @@ transform::Sequential MemoryOpt(tvm::Target host_target, TargetsMap targets) {
IRModule VMCompiler::OptimizeModule(const IRModule& mod, const TargetsMap& targets,
Review comment:
Let's remove the `const` here since we could modify it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi edited a comment on pull request #7451: [VM] Move param bind to OptimizeModule
Posted by GitBox <gi...@apache.org>.
masahi edited a comment on pull request #7451:
URL: https://github.com/apache/tvm/pull/7451#issuecomment-778456108
@icemelon9 Added a test to verify that all params are bound in the output of `vm.optimize()`. This can be checked by counting the number of free vars in the main body. I think this is neat!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on a change in pull request #7451: [VM] Move param bind to OptimizeModule
Posted by GitBox <gi...@apache.org>.
masahi commented on a change in pull request #7451:
URL: https://github.com/apache/tvm/pull/7451#discussion_r574991056
##########
File path: src/relay/backend/vm/compiler.cc
##########
@@ -1007,6 +998,15 @@ transform::Sequential MemoryOpt(tvm::Target host_target, TargetsMap targets) {
IRModule VMCompiler::OptimizeModule(const IRModule& mod, const TargetsMap& targets,
Review comment:
We may want to remove `const` on `mod` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org