[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3899: Array equality for &dyn Array (#3880)

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #3899:
URL: https://github.com/apache/arrow-rs/pull/3899#discussion_r1144079433


##########
arrow-array/src/array/mod.rs:
##########
@@ -425,13 +425,13 @@ pub trait ArrayAccessor: Array {
     unsafe fn value_unchecked(&self, index: usize) -> Self::Item;
 }
 
-impl PartialEq for dyn Array {
+impl PartialEq for dyn Array + '_ {

Review Comment:
   This is the major "fix", previously it would infer a static lifetime for dyn Array, which would then result in incredibly opaque compilation errors



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org