You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/11/18 20:37:00 UTC
[jira] [Commented] (PHOENIX-6078) Remove Internal Phoenix
Connections from parent LinkedQueue when closed
[ https://issues.apache.org/jira/browse/PHOENIX-6078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234998#comment-17234998 ]
ASF GitHub Bot commented on PHOENIX-6078:
-----------------------------------------
gjacoby126 commented on pull request #858:
URL: https://github.com/apache/phoenix/pull/858#issuecomment-729938742
@ChinmaySKulkarni and @sakshamgangwar , what's the status of this PR? I see that it's approved (and skimming through seems pretty straightforward). Any reason it hasn't been committed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Remove Internal Phoenix Connections from parent LinkedQueue when closed
> -----------------------------------------------------------------------
>
> Key: PHOENIX-6078
> URL: https://issues.apache.org/jira/browse/PHOENIX-6078
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.14.3, 4.x
> Reporter: Saksham Gangwar
> Assignee: Saksham Gangwar
> Priority: Major
> Fix For: 4.16.1, 4.17.0
>
> Attachments: PHOENIX-6078.4.x.patch, PHOENIX-6078.4.x.v2.patch, PHOENIX-6078v2.4.x.patch, PHOENIX-6078v3.4.x.patch, PHOENIX-6078v4.4.x.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In https://issues.apache.org/jira/browse/PHOENIX-5872
> We started maintaining parent-child relationships between phoenix connections to close those connections. But after closing those child connections we should be removing them from the Queue which is being maintained for the same.
> Here:
> [https://github.com/apache/phoenix/blob/affa9e889efcc2ad7dac009a0d294b09447d281e/phoenix-core/src/main/java/org/apache/phoenix/compile/MutatingParallelIteratorFactory.java#L114]
>
> If not removed from the queue, and if the parent connection is being reused: we are observing the OOM issue on the container side during the mapper run.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)