You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/06/30 03:37:29 UTC

[GitHub] [hbase] busbey commented on a change in pull request #1992: HBASE-24651 release script utils should set local user when GPG_KEY is defined.

busbey commented on a change in pull request #1992:
URL: https://github.com/apache/hbase/pull/1992#discussion_r447388698



##########
File path: dev-support/create-release/release-util.sh
##########
@@ -20,6 +20,9 @@ DRY_RUN=${DRY_RUN:-1} #default to dry run
 DEBUG=${DEBUG:-0}
 GPG=${GPG:-gpg}
 GPG_ARGS=(--no-autostart --batch)
+if [ -n "${GPG_KEY}" ]; then

Review comment:
       no, in the case of directly running do-release.sh then GPG_KEY isn't defined when we source `release-util.sh`. shortly thereafter we call `get_release_info`, which sets GPG_KEY. (with this change we use GPG_KEY to update GPG_ARGS in that function)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org