You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by koushik-das <gi...@git.apache.org> on 2015/08/26 06:23:41 UTC

[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

GitHub user koushik-das opened a pull request:

    https://github.com/apache/cloudstack/pull/743

    Removed unused agent command AttachVolumeCommand and corresponding an…

    …swer AttachVolumeAnswer
    
    These types are not used anywhere in the orchestration layer.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/koushik-das/cloudstack code_cleanup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/743.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #743
    
----
commit e1db6efc7457b79e2bad90ebf16ad04d74247215
Author: Koushik Das <ko...@apache.org>
Date:   2015-08-26T04:20:23Z

    Removed unused agent command AttachVolumeCommand and corresponding answer AttachVolumeAnswer

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:

    https://github.com/apache/cloudstack/pull/743#issuecomment-134930046
  
    @bhaisaab I am not sure what was the exact purpose of these agent commands. I believe these existed even before the code was donated to Apache. But if you look at the code these are not used anywhere (other than the HV resource layer).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/743#issuecomment-134909228
  
    @koushik-das what are the volume attach/detach agent commands, if these are not being used?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/743#issuecomment-134936442
  
    @koushik-das thanks for replying.
    
    LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:

    https://github.com/apache/cloudstack/pull/743#issuecomment-135395110
  
    Merging as 2 LGTMs


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/743


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/743#issuecomment-135448301
  
    @koushik-das I tried it and it works for me. Can you tell me about your environment (OS, shell, ?) Maybe I might be able to figure it out (line 220 maybe). You can also try to run it using 'bash -x tools/git/git-pr 743` and send me the output. I'll then debug it. Thx!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:

    https://github.com/apache/cloudstack/pull/743#issuecomment-135400836
  
    Output of the tmp file
    
    $cat .git-tmp-message.txt
    Merge pull request #743 from koushik-das/code_cleanup
    
    Removed unused agent command AttachVolumeCommand and corresponding answer AttachVolumeAnswer
    
    These types are not used anywhere in the orchestration layer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

Posted by snuf <gi...@git.apache.org>.
Github user snuf commented on the pull request:

    https://github.com/apache/cloudstack/pull/743#issuecomment-135327593
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:

    https://github.com/apache/cloudstack/pull/743#issuecomment-135398381
  
    @remibergsma I merged this using the tool but still the merge commit didn't automatically get the messages. I manually added some of the messages for now. For another PR also I saw the same. Is the issue not yet fixed?
    
    tools/git/git-pr 743


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---