[GitHub] [flink] KurtYoung commented on a change in pull request #11874: [FLINK-16935][table-planner-blink] Enable or delete most of the ignored test cases in blink planner.

[GitBox <gi...@apache.org>]

KurtYoung commented on a change in pull request #11874:
URL: https://github.com/apache/flink/pull/11874#discussion_r414302741



##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/NonDeterministicTests.scala
##########
@@ -23,71 +23,65 @@ import org.apache.flink.table.api.scala._
 import org.apache.flink.table.planner.expressions.utils.ExpressionTestBase
 import org.apache.flink.types.Row
 
-import org.junit.{Ignore, Test}
+import org.junit.Test
 
 /**
   * Tests that can only be checked manually as they are non-deterministic.
   */
 class NonDeterministicTests extends ExpressionTestBase {
 
-  @Ignore

Review comment:
       I don't think any developer will notice this file and really do the manually check. I would either delete this or change this testing purpose to verify all non-deterministic functions can successfully run




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org