You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "jonvex (via GitHub)" <gi...@apache.org> on 2023/06/01 00:11:40 UTC

[GitHub] [hudi] jonvex opened a new pull request, #8859: set operation to bulk insert on fresh table

jonvex opened a new pull request, #8859:
URL: https://github.com/apache/hudi/pull/8859

   ### Change Logs
   
   _Describe context and summary for this change. Highlight if any code was copied._
   
   ### Impact
   
   _Describe any public API or user-facing feature change or any performance impact._
   
   ### Risk level (write none, low medium or high below)
   
   _If medium or high, explain what verification was done to mitigate the risks._
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8859: set operation to bulk insert on fresh table

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8859:
URL: https://github.com/apache/hudi/pull/8859#issuecomment-1571161385

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641c66d64597d8d83f6234172c3d3dc2c8bc358e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17538",
       "triggerID" : "641c66d64597d8d83f6234172c3d3dc2c8bc358e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 641c66d64597d8d83f6234172c3d3dc2c8bc358e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17538) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8859: set operation to bulk insert on fresh table

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8859:
URL: https://github.com/apache/hudi/pull/8859#issuecomment-1571640814

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641c66d64597d8d83f6234172c3d3dc2c8bc358e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17538",
       "triggerID" : "641c66d64597d8d83f6234172c3d3dc2c8bc358e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0781a5259d9432c5264f642e392b27ca5eadf6fd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17547",
       "triggerID" : "0781a5259d9432c5264f642e392b27ca5eadf6fd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8f4d284eef389ff420b473b9a721212de46302da",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17549",
       "triggerID" : "8f4d284eef389ff420b473b9a721212de46302da",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8f4d284eef389ff420b473b9a721212de46302da Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17549) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8859: set operation to bulk insert on fresh table

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8859:
URL: https://github.com/apache/hudi/pull/8859#issuecomment-1571242238

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641c66d64597d8d83f6234172c3d3dc2c8bc358e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17538",
       "triggerID" : "641c66d64597d8d83f6234172c3d3dc2c8bc358e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 641c66d64597d8d83f6234172c3d3dc2c8bc358e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17538) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] danny0405 commented on a diff in pull request #8859: set operation to bulk insert on fresh table

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8859:
URL: https://github.com/apache/hudi/pull/8859#discussion_r1212585549


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/ProvidesHoodieConfig.scala:
##########
@@ -111,8 +111,13 @@ trait ProvidesHoodieConfig extends Logging {
     val tableType = hoodieCatalogTable.tableTypeName
     val tableConfig = hoodieCatalogTable.tableConfig
 
-    val combinedOpts: Map[String, String] = combineOptions(hoodieCatalogTable, tableConfig, sparkSession.sqlContext.conf,
+    var combinedOpts: Map[String, String] = combineOptions(hoodieCatalogTable, tableConfig, sparkSession.sqlContext.conf,
       defaultOpts = Map.empty, overridingOpts = extraOptions)
+    if (!combinedOpts.getOrElse(INSERT_DROP_DUPS.key(),INSERT_DROP_DUPS.defaultValue()).toBoolean &&

Review Comment:
   ```suggestion
       if (!combinedOpts.getOrElse(INSERT_DROP_DUPS.key(), INSERT_DROP_DUPS.defaultValue()).toBoolean &&
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8859: set operation to bulk insert on fresh table

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8859:
URL: https://github.com/apache/hudi/pull/8859#issuecomment-1571301873

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641c66d64597d8d83f6234172c3d3dc2c8bc358e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17538",
       "triggerID" : "641c66d64597d8d83f6234172c3d3dc2c8bc358e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0781a5259d9432c5264f642e392b27ca5eadf6fd",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17547",
       "triggerID" : "0781a5259d9432c5264f642e392b27ca5eadf6fd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 641c66d64597d8d83f6234172c3d3dc2c8bc358e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17538) 
   * 0781a5259d9432c5264f642e392b27ca5eadf6fd Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17547) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8859: set operation to bulk insert on fresh table

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8859:
URL: https://github.com/apache/hudi/pull/8859#issuecomment-1571296743

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641c66d64597d8d83f6234172c3d3dc2c8bc358e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17538",
       "triggerID" : "641c66d64597d8d83f6234172c3d3dc2c8bc358e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0781a5259d9432c5264f642e392b27ca5eadf6fd",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0781a5259d9432c5264f642e392b27ca5eadf6fd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 641c66d64597d8d83f6234172c3d3dc2c8bc358e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17538) 
   * 0781a5259d9432c5264f642e392b27ca5eadf6fd UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8859: set operation to bulk insert on fresh table

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8859:
URL: https://github.com/apache/hudi/pull/8859#issuecomment-1571335287

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641c66d64597d8d83f6234172c3d3dc2c8bc358e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17538",
       "triggerID" : "641c66d64597d8d83f6234172c3d3dc2c8bc358e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0781a5259d9432c5264f642e392b27ca5eadf6fd",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17547",
       "triggerID" : "0781a5259d9432c5264f642e392b27ca5eadf6fd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8f4d284eef389ff420b473b9a721212de46302da",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8f4d284eef389ff420b473b9a721212de46302da",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 641c66d64597d8d83f6234172c3d3dc2c8bc358e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17538) 
   * 0781a5259d9432c5264f642e392b27ca5eadf6fd Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17547) 
   * 8f4d284eef389ff420b473b9a721212de46302da UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] jonvex closed pull request #8859: set operation to bulk insert on fresh table

Posted by "jonvex (via GitHub)" <gi...@apache.org>.
jonvex closed pull request #8859: set operation to bulk insert on fresh table
URL: https://github.com/apache/hudi/pull/8859


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8859: set operation to bulk insert on fresh table

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8859:
URL: https://github.com/apache/hudi/pull/8859#issuecomment-1571341385

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641c66d64597d8d83f6234172c3d3dc2c8bc358e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17538",
       "triggerID" : "641c66d64597d8d83f6234172c3d3dc2c8bc358e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0781a5259d9432c5264f642e392b27ca5eadf6fd",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17547",
       "triggerID" : "0781a5259d9432c5264f642e392b27ca5eadf6fd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8f4d284eef389ff420b473b9a721212de46302da",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17549",
       "triggerID" : "8f4d284eef389ff420b473b9a721212de46302da",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0781a5259d9432c5264f642e392b27ca5eadf6fd Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17547) 
   * 8f4d284eef389ff420b473b9a721212de46302da Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17549) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8859: set operation to bulk insert on fresh table

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8859:
URL: https://github.com/apache/hudi/pull/8859#issuecomment-1571153750

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "641c66d64597d8d83f6234172c3d3dc2c8bc358e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "641c66d64597d8d83f6234172c3d3dc2c8bc358e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 641c66d64597d8d83f6234172c3d3dc2c8bc358e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org