You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by chaitali <ch...@freestoneinfotech.com> on 2021/09/06 08:45:43 UTC

Re: Review Request 73528: ATLAS-4377 : Atlas - Upgrade Spring Security to 5.4.4+/5.3.8+/5.2.9+

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73528/
-----------------------------------------------------------

(Updated Sept. 6, 2021, 8:45 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-4377
    https://issues.apache.org/jira/browse/ATLAS-4377


Repository: atlas


Description
-------

Atlas is pulling in Spring security 4.2.17.RELEASE upgrade to 5.4.4, 5.3.8, or 5.2.9
Upgrading spring-security version to 5.5.1 this is the latest
Upgrading spring-core version to 5.3.8 current version 4.3.29.RELEASE


Diffs (updated)
-----

  addons/falcon-bridge-shim/pom.xml 02da049db 
  addons/falcon-bridge/pom.xml e0d2f3be7 
  authorization/pom.xml 8e5a85db4 
  common/src/main/java/org/apache/atlas/utils/OnAtlasPropertyCondition.java ece6e370a 
  pom.xml 8ae338cf2 
  repository/pom.xml bf34efee2 
  repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java 343d00d72 
  test-tools/pom.xml c861ea67f 
  webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java e16796ff6 
  webapp/src/main/java/org/apache/atlas/web/util/Servlets.java 71eca2e50 
  webapp/src/main/webapp/WEB-INF/web.xml 7fb56efde 
  webapp/src/test/java/org/apache/atlas/web/security/UserDaoTest.java 519be804e 
  webapp/src/test/webapp/WEB-INF/web.xml 2388fbfbb 


Diff: https://reviews.apache.org/r/73528/diff/3/

Changes: https://reviews.apache.org/r/73528/diff/2-3/


Testing
-------

mvn clean package -Pdist,embedded-hbase-solr -DskipTests -Drat.skip
Atlas server runnning
mvn clean install  -DskipTests
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/811/console


Thanks,

chaitali


Re: Review Request 73528: ATLAS-4377 : Atlas - Upgrade Spring Security to 5.4.4+/5.3.8+/5.2.9+

Posted by chaitali <ch...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73528/
-----------------------------------------------------------

(Updated Sept. 14, 2021, 5:59 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-4377
    https://issues.apache.org/jira/browse/ATLAS-4377


Repository: atlas


Description
-------

Atlas is pulling in Spring security 4.2.17.RELEASE upgrade to 5.4.4, 5.3.8, or 5.2.9
Upgrading spring-security version to 5.5.1 this is the latest
Upgrading spring-core version to 5.3.8 current version 4.3.29.RELEASE


Diffs
-----

  addons/falcon-bridge-shim/pom.xml 02da049db 
  addons/falcon-bridge/pom.xml e0d2f3be7 
  authorization/pom.xml 8e5a85db4 
  common/src/main/java/org/apache/atlas/utils/OnAtlasPropertyCondition.java ece6e370a 
  pom.xml 8ae338cf2 
  repository/pom.xml bf34efee2 
  repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java 343d00d72 
  test-tools/pom.xml c861ea67f 
  webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java e16796ff6 
  webapp/src/main/java/org/apache/atlas/web/util/Servlets.java 71eca2e50 
  webapp/src/main/webapp/WEB-INF/web.xml 7fb56efde 
  webapp/src/test/java/org/apache/atlas/web/security/UserDaoTest.java 519be804e 
  webapp/src/test/webapp/WEB-INF/web.xml 2388fbfbb 


Diff: https://reviews.apache.org/r/73528/diff/3/


Testing (updated)
-------

mvn clean package -Pdist,embedded-hbase-solr -DskipTests -Drat.skip
Atlas server runnning
mvn clean install  -DskipTests
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/811/console

LatestPC
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/843/console


Thanks,

chaitali


Re: Review Request 73528: ATLAS-4377 : Atlas - Upgrade Spring Security to 5.4.4+/5.3.8+/5.2.9+

Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73528/#review223463
-----------------------------------------------------------


Ship it!




Ship It!


common/src/main/java/org/apache/atlas/utils/OnAtlasPropertyCondition.java
Line 40 (original), 40 (patched)
<https://reviews.apache.org/r/73528/#comment312549>

    Good.


- Ashutosh Mestry


On Sept. 6, 2021, 8:45 a.m., chaitali wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73528/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2021, 8:45 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4377
>     https://issues.apache.org/jira/browse/ATLAS-4377
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Atlas is pulling in Spring security 4.2.17.RELEASE upgrade to 5.4.4, 5.3.8, or 5.2.9
> Upgrading spring-security version to 5.5.1 this is the latest
> Upgrading spring-core version to 5.3.8 current version 4.3.29.RELEASE
> 
> 
> Diffs
> -----
> 
>   addons/falcon-bridge-shim/pom.xml 02da049db 
>   addons/falcon-bridge/pom.xml e0d2f3be7 
>   authorization/pom.xml 8e5a85db4 
>   common/src/main/java/org/apache/atlas/utils/OnAtlasPropertyCondition.java ece6e370a 
>   pom.xml 8ae338cf2 
>   repository/pom.xml bf34efee2 
>   repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java 343d00d72 
>   test-tools/pom.xml c861ea67f 
>   webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java e16796ff6 
>   webapp/src/main/java/org/apache/atlas/web/util/Servlets.java 71eca2e50 
>   webapp/src/main/webapp/WEB-INF/web.xml 7fb56efde 
>   webapp/src/test/java/org/apache/atlas/web/security/UserDaoTest.java 519be804e 
>   webapp/src/test/webapp/WEB-INF/web.xml 2388fbfbb 
> 
> 
> Diff: https://reviews.apache.org/r/73528/diff/3/
> 
> 
> Testing
> -------
> 
> mvn clean package -Pdist,embedded-hbase-solr -DskipTests -Drat.skip
> Atlas server runnning
> mvn clean install  -DskipTests
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/811/console
> 
> 
> Thanks,
> 
> chaitali
> 
>


Re: Review Request 73528: ATLAS-4377 : Atlas - Upgrade Spring Security to 5.4.4+/5.3.8+/5.2.9+

Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73528/#review223466
-----------------------------------------------------------


Ship it!




Ship It!

- Sarath Subramanian


On Sept. 6, 2021, 1:45 a.m., chaitali wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73528/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2021, 1:45 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4377
>     https://issues.apache.org/jira/browse/ATLAS-4377
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Atlas is pulling in Spring security 4.2.17.RELEASE upgrade to 5.4.4, 5.3.8, or 5.2.9
> Upgrading spring-security version to 5.5.1 this is the latest
> Upgrading spring-core version to 5.3.8 current version 4.3.29.RELEASE
> 
> 
> Diffs
> -----
> 
>   addons/falcon-bridge-shim/pom.xml 02da049db 
>   addons/falcon-bridge/pom.xml e0d2f3be7 
>   authorization/pom.xml 8e5a85db4 
>   common/src/main/java/org/apache/atlas/utils/OnAtlasPropertyCondition.java ece6e370a 
>   pom.xml 8ae338cf2 
>   repository/pom.xml bf34efee2 
>   repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java 343d00d72 
>   test-tools/pom.xml c861ea67f 
>   webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java e16796ff6 
>   webapp/src/main/java/org/apache/atlas/web/util/Servlets.java 71eca2e50 
>   webapp/src/main/webapp/WEB-INF/web.xml 7fb56efde 
>   webapp/src/test/java/org/apache/atlas/web/security/UserDaoTest.java 519be804e 
>   webapp/src/test/webapp/WEB-INF/web.xml 2388fbfbb 
> 
> 
> Diff: https://reviews.apache.org/r/73528/diff/3/
> 
> 
> Testing
> -------
> 
> mvn clean package -Pdist,embedded-hbase-solr -DskipTests -Drat.skip
> Atlas server runnning
> mvn clean install  -DskipTests
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/811/console
> 
> 
> Thanks,
> 
> chaitali
> 
>