You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ranger.apache.org by Pradeep Agrawal <pr...@gmail.com> on 2022/07/12 17:07:55 UTC

Re: Review Request 74030: RANGER-3794: Improve performance of delete users/groups utility

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74030/#review224555
-----------------------------------------------------------


Ship it!




Ship It!

- Pradeep Agrawal


On June 17, 2022, 3:37 p.m., Fateh Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74030/
> -----------------------------------------------------------
> 
> (Updated June 17, 2022, 3:37 p.m.)
> 
> 
> Review request for ranger, bhavik patel, Dhaval Shah, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3794
>     https://issues.apache.org/jira/browse/RANGER-3794
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Problem Statement: deleteUserGroupUtil.py is a utility to delete users/groups from ranger when a user provides a list of users/groups to delete. Currently it takes around 9 seconds per user to delete.
> 
> Problem Solution: Currently the script users pycurl package and makes independent curl/http requests for every user/group to be deleted. This does not share cookies used between multiple http requests. Current changes include sharing of cookies between requests by creation of a session which persists during the lifetime of the script. We do this by using "requests" package rather than the "pycurl" package. This helps reduce the execution time to 5.3 seconds per deletion.
> 
> 
> Diffs
> -----
> 
>   security-admin/scripts/deleteUserGroupUtil.py 1c9f58385 
> 
> 
> Diff: https://reviews.apache.org/r/74030/diff/1/
> 
> 
> Testing
> -------
> 
> 1) Installed ranger from master branch build
> 2) Applied the patch on Apache ranger master branch on the deleteUserGroupUtil.py script
> 3) Evaluate performance of script by noting time of execution of script using different number of users to delete (1,10,100 & 1000) using python2.7 and python3.9
> 
> 
> Thanks,
> 
> Fateh Singh
> 
>