You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by ji...@apache.org on 2008/05/07 19:32:33 UTC
svn commit: r654185 - in /apr/apr/trunk: CHANGES network_io/unix/sendrecv.c
Author: jim
Date: Wed May 7 10:32:31 2008
New Revision: 654185
URL: http://svn.apache.org/viewvc?rev=654185&view=rev
Log:
Make Darwin's sendfile() really work :)
Modified:
apr/apr/trunk/CHANGES
apr/apr/trunk/network_io/unix/sendrecv.c
Modified: apr/apr/trunk/CHANGES
URL: http://svn.apache.org/viewvc/apr/apr/trunk/CHANGES?rev=654185&r1=654184&r2=654185&view=diff
==============================================================================
--- apr/apr/trunk/CHANGES [utf-8] (original)
+++ apr/apr/trunk/CHANGES [utf-8] Wed May 7 10:32:31 2008
@@ -51,7 +51,7 @@
allocation. [David Jones <oscaremma gmail.com>]
*) Implement Darwin-semantic (9.0.0 and later) sendfile support.
- [William Rowe]
+ [William Rowe, Jim Jagielski]
*) Implemented the APR_FOPEN_SPARSE flag, permits win32 to create
sparse data files. Also bestow apr_fileinfo_t csize field for
Modified: apr/apr/trunk/network_io/unix/sendrecv.c
URL: http://svn.apache.org/viewvc/apr/apr/trunk/network_io/unix/sendrecv.c?rev=654185&r1=654184&r2=654185&view=diff
==============================================================================
--- apr/apr/trunk/network_io/unix/sendrecv.c (original)
+++ apr/apr/trunk/network_io/unix/sendrecv.c Wed May 7 10:32:31 2008
@@ -472,7 +472,6 @@
if (errno == EAGAIN) {
if (sock->timeout > 0) {
sock->options |= APR_INCOMPLETE_WRITE;
- rv = 0;
}
/* BSD's sendfile can return -1/EAGAIN even if it
* sent bytes. Sanitize the result so we get normal EAGAIN
Re: svn commit: r654185 - in /apr/apr/trunk: CHANGES network_io/unix/sendrecv.c
Posted by Jim Jagielski <ji...@apache.org>.
Is it better to combine them both into 1 ??
On May 7, 2008, at 3:04 PM, William A. Rowe, Jr. wrote:
> jim@apache.org wrote:
>> Author: jim
>> Date: Wed May 7 10:32:31 2008
>> New Revision: 654185
>> URL: http://svn.apache.org/viewvc?rev=654185&view=rev
>> Log:
>> Make Darwin's sendfile() really work :)
>
> I forgot about that CHANGES entry... Jim would you also please add
> Geoff Greer <angryparsley mipsisrisc.com> to that list of helpful
> people who fixed this implementation?
>
> Bill
>
Re: svn commit: r654185 - in /apr/apr/trunk: CHANGES network_io/unix/sendrecv.c
Posted by Jim Jagielski <ji...@apache.org>.
Is it better to combine them both into 1 ??
On May 7, 2008, at 3:04 PM, William A. Rowe, Jr. wrote:
> jim@apache.org wrote:
>> Author: jim
>> Date: Wed May 7 10:32:31 2008
>> New Revision: 654185
>> URL: http://svn.apache.org/viewvc?rev=654185&view=rev
>> Log:
>> Make Darwin's sendfile() really work :)
>
> I forgot about that CHANGES entry... Jim would you also please add
> Geoff Greer <angryparsley mipsisrisc.com> to that list of helpful
> people who fixed this implementation?
>
> Bill
>
Re: svn commit: r654185 - in /apr/apr/trunk: CHANGES network_io/unix/sendrecv.c
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
jim@apache.org wrote:
> Author: jim
> Date: Wed May 7 10:32:31 2008
> New Revision: 654185
>
> URL: http://svn.apache.org/viewvc?rev=654185&view=rev
> Log:
> Make Darwin's sendfile() really work :)
I forgot about that CHANGES entry... Jim would you also please add
Geoff Greer <angryparsley mipsisrisc.com> to that list of helpful
people who fixed this implementation?
Bill
Re: svn commit: r654185 - in /apr/apr/trunk: CHANGES network_io/unix/sendrecv.c
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
jim@apache.org wrote:
> Author: jim
> Date: Wed May 7 10:32:31 2008
> New Revision: 654185
>
> URL: http://svn.apache.org/viewvc?rev=654185&view=rev
> Log:
> Make Darwin's sendfile() really work :)
I forgot about that CHANGES entry... Jim would you also please add
Geoff Greer <angryparsley mipsisrisc.com> to that list of helpful
people who fixed this implementation?
Bill