You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/01/29 00:12:28 UTC
[GitHub] [druid] zachjsh opened a new pull request #12211: Reduce RemoteTaskRunnerTest flakiness
zachjsh opened a new pull request #12211:
URL: https://github.com/apache/druid/pull/12211
It was found that tests in this test class occasionally fail because the certain work expected to be completed isn't done within the timeout period, 1 second. These failures are seen more often when the CI system is under heavy load. The thread that is responsible for doing the work that is best tested may not have chance to run within this period of time. The timeout period is configured to be 5 minutes by default in production, so changing the timeout to the test to be something more reasonable, 30 seconds.
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [x] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s merged pull request #12211: Reduce RemoteTaskRunnerTest flakiness
Posted by GitBox <gi...@apache.org>.
suneet-s merged pull request #12211:
URL: https://github.com/apache/druid/pull/12211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on a change in pull request #12211: Reduce RemoteTaskRunnerTest flakiness
Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #12211:
URL: https://github.com/apache/druid/pull/12211#discussion_r795888841
##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/RemoteTaskRunner.java
##########
@@ -223,6 +223,7 @@ public void start()
return;
}
try {
+ log.info("Starting...");
Review comment:
```suggestion
log.info("Starting RemoteTaskRunner...");
```
##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/RemoteTaskRunner.java
##########
@@ -350,6 +351,7 @@ public void stop()
return;
}
try {
+ log.info("Stopping...");
Review comment:
I noticed the HttpRemoteTaskRunner and SegmentLoadDropHandler also just have logs that say `Starting...` and `Stopping...` To make the logs easier to follow, I think it's better to add some more identifying info to the logs.
`WorkTaskManager` also has a debug log `Starting...`
```suggestion
log.info("Stopping RemoteTaskRunner...");
```
Would you mind fixing up these logs too if you're going to make another patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org