You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by pu...@apache.org on 2018/10/04 07:14:23 UTC

[royale-asjs] branch develop updated: Update CategoryAxis.as

This is an automated email from the ASF dual-hosted git repository.

pushminakazi pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new e2a7a4c  Update CategoryAxis.as
e2a7a4c is described below

commit e2a7a4c53cad37a0c3a398906c3b6f5b4eda2b17
Author: pashminakazi <42...@users.noreply.github.com>
AuthorDate: Thu Oct 4 12:14:19 2018 +0500

    Update CategoryAxis.as
---
 .../projects/MXRoyale/src/main/royale/mx/charts/CategoryAxis.as      | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/frameworks/projects/MXRoyale/src/main/royale/mx/charts/CategoryAxis.as b/frameworks/projects/MXRoyale/src/main/royale/mx/charts/CategoryAxis.as
index 087ec96..949e4a8 100644
--- a/frameworks/projects/MXRoyale/src/main/royale/mx/charts/CategoryAxis.as
+++ b/frameworks/projects/MXRoyale/src/main/royale/mx/charts/CategoryAxis.as
@@ -24,7 +24,6 @@ package mx.charts
 
 import mx.charts.chartClasses.AxisBase;
 import mx.charts.chartClasses.AxisLabelSet;
-import mx.charts.chartClasses.IAxis;
 import mx.collections.ArrayCollection;
 import mx.collections.CursorBookmark;
 import mx.collections.IViewCursor;
@@ -34,6 +33,8 @@ import mx.events.CollectionEvent;
 import mx.events.CollectionEventKind;
 use namespace mx_internal; */
 import mx.collections.ICollectionView;
+import mx.core.UIComponent;
+import mx.charts.chartClasses.IAxis;
 
 /**
  *  The CategoryAxis class lets charts represent data
@@ -85,7 +86,7 @@ import mx.collections.ICollectionView;
  *  @playerversion AIR 1.1
  *  @productversion Royale 0.9.3
  */
-public class CategoryAxis 
+public class CategoryAxis extends UIComponent implements IAxis
 {
 //extends AxisBase implements IAxis

Re: [royale-asjs] branch develop updated: Update CategoryAxis.as

Posted by Alex Harui <ah...@adobe.com.INVALID>.
I don't think CategoryAxis should be a UIComponent.  It doesn't look like it was in Flex.  Check the Flex class inheritance when choosing a base class.  You don't always have to use the same base class, but it should help you decide whether it should be a UIComponent or not.

Thanks,
-Alex

On 10/4/18, 12:14 AM, "pushminakazi@apache.org" <pu...@apache.org> wrote:

    This is an automated email from the ASF dual-hosted git repository.
    
    pushminakazi pushed a commit to branch develop
    in repository https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&amp;data=02%7C01%7Caharui%40adobe.com%7C46dd405fdbd74444a5fa08d629c90381%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636742340679975618&amp;sdata=hPY5gw2tusSbfW6Qu8kWLJG8GScRUeutmRHPLA4Ebxc%3D&amp;reserved=0
    
    
    The following commit(s) were added to refs/heads/develop by this push:
         new e2a7a4c  Update CategoryAxis.as
    e2a7a4c is described below
    
    commit e2a7a4c53cad37a0c3a398906c3b6f5b4eda2b17
    Author: pashminakazi <42...@users.noreply.github.com>
    AuthorDate: Thu Oct 4 12:14:19 2018 +0500
    
        Update CategoryAxis.as
    ---
     .../projects/MXRoyale/src/main/royale/mx/charts/CategoryAxis.as      | 5 +++--
     1 file changed, 3 insertions(+), 2 deletions(-)
    
    diff --git a/frameworks/projects/MXRoyale/src/main/royale/mx/charts/CategoryAxis.as b/frameworks/projects/MXRoyale/src/main/royale/mx/charts/CategoryAxis.as
    index 087ec96..949e4a8 100644
    --- a/frameworks/projects/MXRoyale/src/main/royale/mx/charts/CategoryAxis.as
    +++ b/frameworks/projects/MXRoyale/src/main/royale/mx/charts/CategoryAxis.as
    @@ -24,7 +24,6 @@ package mx.charts
     
     import mx.charts.chartClasses.AxisBase;
     import mx.charts.chartClasses.AxisLabelSet;
    -import mx.charts.chartClasses.IAxis;
     import mx.collections.ArrayCollection;
     import mx.collections.CursorBookmark;
     import mx.collections.IViewCursor;
    @@ -34,6 +33,8 @@ import mx.events.CollectionEvent;
     import mx.events.CollectionEventKind;
     use namespace mx_internal; */
     import mx.collections.ICollectionView;
    +import mx.core.UIComponent;
    +import mx.charts.chartClasses.IAxis;
     
     /**
      *  The CategoryAxis class lets charts represent data
    @@ -85,7 +86,7 @@ import mx.collections.ICollectionView;
      *  @playerversion AIR 1.1
      *  @productversion Royale 0.9.3
      */
    -public class CategoryAxis 
    +public class CategoryAxis extends UIComponent implements IAxis
     {
     //extends AxisBase implements IAxis