[GitHub] [incubator-superset] nytai commented on pull request #9655: chore: add support for gitlint: a commit msg linter

[GitBox <gi...@apache.org>]

nytai commented on pull request #9655:
URL: https://github.com/apache/incubator-superset/pull/9655#issuecomment-619623021


   I agree with @ktmud a per check would be preferable. We can even enforce semantic commits on the actual PR. A local pre-commit check seems like it could get annoying really quickly. I usually fixup my commits or reword them before opening a pr or when submitting pr for final review, especially given the commit messages get squashed into the commit that's finally merged. However, I commit often when developing locally for things like moving branches or commits I intend to fixup. Having to write a message that'll pass commit lint, not to mention running commit lint, when I just want to save my work and move to another branch seems tedious. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org