You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2021/07/30 23:08:51 UTC

[commons-statistics] 03/06: Simplify probability using logProbability

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-statistics.git

commit 7db9d2210ce62879353780f8447e7e9f6255e493
Author: Alex Herbert <ah...@apache.org>
AuthorDate: Fri Jul 30 21:29:44 2021 +0100

    Simplify probability using logProbability
---
 .../apache/commons/statistics/distribution/BinomialDistribution.java   | 3 +--
 .../commons/statistics/distribution/HypergeometricDistribution.java    | 3 +--
 .../apache/commons/statistics/distribution/PoissonDistribution.java    | 3 +--
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/BinomialDistribution.java b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/BinomialDistribution.java
index 506a73a..d9dcc64 100644
--- a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/BinomialDistribution.java
+++ b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/BinomialDistribution.java
@@ -71,8 +71,7 @@ public class BinomialDistribution extends AbstractDiscreteDistribution {
     /** {@inheritDoc} */
     @Override
     public double probability(int x) {
-        final double logProbability = logProbability(x);
-        return logProbability == Double.NEGATIVE_INFINITY ? 0 : Math.exp(logProbability);
+        return Math.exp(logProbability(x));
     }
 
     /** {@inheritDoc} **/
diff --git a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/HypergeometricDistribution.java b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/HypergeometricDistribution.java
index 7ccb411..6dc6a6a 100644
--- a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/HypergeometricDistribution.java
+++ b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/HypergeometricDistribution.java
@@ -129,8 +129,7 @@ public class HypergeometricDistribution extends AbstractDiscreteDistribution {
     /** {@inheritDoc} */
     @Override
     public double probability(int x) {
-        final double logProbability = logProbability(x);
-        return logProbability == Double.NEGATIVE_INFINITY ? 0 : Math.exp(logProbability);
+        return Math.exp(logProbability(x));
     }
 
     /** {@inheritDoc} */
diff --git a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/PoissonDistribution.java b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/PoissonDistribution.java
index 8444627..bef39c6 100644
--- a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/PoissonDistribution.java
+++ b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/PoissonDistribution.java
@@ -75,8 +75,7 @@ public class PoissonDistribution extends AbstractDiscreteDistribution {
     /** {@inheritDoc} */
     @Override
     public double probability(int x) {
-        final double logProbability = logProbability(x);
-        return logProbability == Double.NEGATIVE_INFINITY ? 0 : Math.exp(logProbability);
+        return Math.exp(logProbability(x));
     }
 
     /** {@inheritDoc} */