You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Martijn van Groningen (JIRA)" <ji...@apache.org> on 2012/05/18 16:47:07 UTC
[jira] [Created] (LUCENE-4068) Improve IW#addDocuments(...) javadoc
Martijn van Groningen created LUCENE-4068:
---------------------------------------------
Summary: Improve IW#addDocuments(...) javadoc
Key: LUCENE-4068
URL: https://issues.apache.org/jira/browse/LUCENE-4068
Project: Lucene - Java
Issue Type: Improvement
Reporter: Martijn van Groningen
Priority: Minor
Improve IW#addDocuments(...) javadoc.
Describer how blocks can be used regarding to index updates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4068) Improve IW#addDocuments(...)
javadoc
Posted by "Martijn van Groningen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278954#comment-13278954 ]
Martijn van Groningen commented on LUCENE-4068:
-----------------------------------------------
Yes... someone could delete a parent without deleting its children. I guess that this a responsibility of the application using Lucene. Right now for updating the deleteDocuments(query) method should be used, before using updateDocuments(...) / addDocuments(...)
The updateDocuments method that uses the delQuery could include a ToChildBlockJoinQuery instance (as part of a boolean query) that would matches to the children documents (in case a parent document were to be deleted). However this logic would then still be the apps responsibility.
> Improve IW#addDocuments(...) javadoc
> ------------------------------------
>
> Key: LUCENE-4068
> URL: https://issues.apache.org/jira/browse/LUCENE-4068
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 3.2, 3.3, 3.4, 3.5, 3.6, 4.0
> Reporter: Martijn van Groningen
> Priority: Minor
> Fix For: 4.0, 3.6.1
>
> Attachments: LUCENE-4068.patch, LUCENE-4068.patch
>
>
> Improve IW#addDocuments(...) javadoc.
> Describer how blocks can be used regarding to index updates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4068) Improve IW#addDocuments(...) javadoc
Posted by "Martijn van Groningen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn van Groningen updated LUCENE-4068:
------------------------------------------
Attachment: LUCENE-4068.patch
{quote}
Maybe instead of ". Also when documents inside a block are deleted" say ", even when child documents within a block are deleted"? (Ie, one sentence not two, and add "child" since you cannot delete the parent w/o deleting all of its children).
{quote}
Done.
bq. Also, can we not change the imports to wildcards?
Done. My IDE did this on the fly...
> Improve IW#addDocuments(...) javadoc
> ------------------------------------
>
> Key: LUCENE-4068
> URL: https://issues.apache.org/jira/browse/LUCENE-4068
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 3.2, 3.3, 3.4, 3.5, 3.6, 4.0
> Reporter: Martijn van Groningen
> Priority: Minor
> Fix For: 4.0, 3.6.1
>
> Attachments: LUCENE-4068.patch, LUCENE-4068.patch
>
>
> Improve IW#addDocuments(...) javadoc.
> Describer how blocks can be used regarding to index updates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4068) Improve IW#addDocuments(...)
javadoc
Posted by "Martijn van Groningen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278991#comment-13278991 ]
Martijn van Groningen commented on LUCENE-4068:
-----------------------------------------------
True, that isn't atomic.
> Improve IW#addDocuments(...) javadoc
> ------------------------------------
>
> Key: LUCENE-4068
> URL: https://issues.apache.org/jira/browse/LUCENE-4068
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 3.2, 3.3, 3.4, 3.5, 3.6, 4.0
> Reporter: Martijn van Groningen
> Priority: Minor
> Fix For: 4.0, 3.6.1
>
> Attachments: LUCENE-4068.patch, LUCENE-4068.patch
>
>
> Improve IW#addDocuments(...) javadoc.
> Describer how blocks can be used regarding to index updates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4068) Improve IW#addDocuments(...) javadoc
Posted by "Martijn van Groningen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn van Groningen updated LUCENE-4068:
------------------------------------------
Attachment: LUCENE-4068.patch
Added better description how to deal with updates.
The javadoc also states that future merging might not preserves blocks. Currently this isn't the case. Is this still true for upcoming SegmentMerger implementations? Maybe when this will be the case then better protection should be in place. Like storing the document blocks in the index.
> Improve IW#addDocuments(...) javadoc
> ------------------------------------
>
> Key: LUCENE-4068
> URL: https://issues.apache.org/jira/browse/LUCENE-4068
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Martijn van Groningen
> Priority: Minor
> Attachments: LUCENE-4068.patch
>
>
> Improve IW#addDocuments(...) javadoc.
> Describer how blocks can be used regarding to index updates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-4068) Improve IW#addDocuments(...)
javadoc
Posted by "Martijn van Groningen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn van Groningen resolved LUCENE-4068.
-------------------------------------------
Resolution: Fixed
Committed to trunk and 3.6 branch.
> Improve IW#addDocuments(...) javadoc
> ------------------------------------
>
> Key: LUCENE-4068
> URL: https://issues.apache.org/jira/browse/LUCENE-4068
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 3.2, 3.3, 3.4, 3.5, 3.6, 4.0
> Reporter: Martijn van Groningen
> Priority: Minor
> Fix For: 4.0, 3.6.1
>
> Attachments: LUCENE-4068.patch, LUCENE-4068.patch
>
>
> Improve IW#addDocuments(...) javadoc.
> Describer how blocks can be used regarding to index updates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4068) Improve IW#addDocuments(...) javadoc
Posted by "Martijn van Groningen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn van Groningen updated LUCENE-4068:
------------------------------------------
Affects Version/s: 4.0
3.2
3.3
3.4
3.5
3.6
Fix Version/s: 3.6.1
4.0
> Improve IW#addDocuments(...) javadoc
> ------------------------------------
>
> Key: LUCENE-4068
> URL: https://issues.apache.org/jira/browse/LUCENE-4068
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 3.2, 3.3, 3.4, 3.5, 3.6, 4.0
> Reporter: Martijn van Groningen
> Priority: Minor
> Fix For: 4.0, 3.6.1
>
> Attachments: LUCENE-4068.patch, LUCENE-4068.patch
>
>
> Improve IW#addDocuments(...) javadoc.
> Describer how blocks can be used regarding to index updates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4068) Improve IW#addDocuments(...)
javadoc
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278880#comment-13278880 ]
Michael McCandless commented on LUCENE-4068:
--------------------------------------------
Looks good!
Maybe instead of ". Also when documents inside a block are deleted" say ", even when child documents within a block are deleted"? (Ie, one sentence not two, and add "child" since you cannot delete the parent w/o deleting all of its children).
Also, can we not change the imports to wildcards?
> Improve IW#addDocuments(...) javadoc
> ------------------------------------
>
> Key: LUCENE-4068
> URL: https://issues.apache.org/jira/browse/LUCENE-4068
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Martijn van Groningen
> Priority: Minor
> Attachments: LUCENE-4068.patch
>
>
> Improve IW#addDocuments(...) javadoc.
> Describer how blocks can be used regarding to index updates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4068) Improve IW#addDocuments(...)
javadoc
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278977#comment-13278977 ]
Yonik Seeley commented on LUCENE-4068:
--------------------------------------
bq. Right now for updating the deleteDocuments(query) method should be used, before using updateDocuments(...) / addDocuments(...)
Sure - but my point is that isn't atomic. That's why the updateDocument* methods exist in the first place (as opposed to doing separate deletes and then adds).
> Improve IW#addDocuments(...) javadoc
> ------------------------------------
>
> Key: LUCENE-4068
> URL: https://issues.apache.org/jira/browse/LUCENE-4068
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 3.2, 3.3, 3.4, 3.5, 3.6, 4.0
> Reporter: Martijn van Groningen
> Priority: Minor
> Fix For: 4.0, 3.6.1
>
> Attachments: LUCENE-4068.patch, LUCENE-4068.patch
>
>
> Improve IW#addDocuments(...) javadoc.
> Describer how blocks can be used regarding to index updates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4068) Improve IW#addDocuments(...)
javadoc
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278913#comment-13278913 ]
Yonik Seeley commented on LUCENE-4068:
--------------------------------------
bq. you cannot delete the parent w/o deleting all of its children
Atomic update seems a bit tricky...
Perhaps this
{code}
public void updateDocuments(Term delTerm, Iterable<? extends Iterable<? extends IndexableField>> docs, Analyzer analyzer) throws CorruptIndexException, IOException {
{code}
should be something like
{code}
public void updateDocuments(Iterable<Term>, Iterable<? extends Iterable<? extends IndexableField>> docs, Analyzer analyzer) throws CorruptIndexException, IOException {
{code}
or perhaps even more generic:
{code}
public void updateDocuments(Query delQuery, Iterable<? extends Iterable<? extends IndexableField>> docs, Analyzer analyzer) throws CorruptIndexException, IOException {
{code}
> Improve IW#addDocuments(...) javadoc
> ------------------------------------
>
> Key: LUCENE-4068
> URL: https://issues.apache.org/jira/browse/LUCENE-4068
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 3.2, 3.3, 3.4, 3.5, 3.6, 4.0
> Reporter: Martijn van Groningen
> Priority: Minor
> Fix For: 4.0, 3.6.1
>
> Attachments: LUCENE-4068.patch, LUCENE-4068.patch
>
>
> Improve IW#addDocuments(...) javadoc.
> Describer how blocks can be used regarding to index updates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org