You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/07/14 19:16:01 UTC
Review Request 60879: Preventing agent recovery failing from
unsuccessful `docker rm`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60879/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Jie Yu.
Bugs: MESOS-7777
https://issues.apache.org/jira/browse/MESOS-7777
Repository: mesos
Description
-------
This patch changes the semancits of `Docker::stop()` to do a best-effort
`docker rm` and log the error instead of returning the failure, as a
workaround of the mount namespace leakage issue in Docker 1.12/1.13.
Diffs
-----
src/docker/docker.cpp 8ca0c68836ea5d1a1186e79942f6daccf6c6da46
Diff: https://reviews.apache.org/r/60879/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 60879: Preventing agent recovery failing from
unsuccessful `docker rm`.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60879/#review180589
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On July 14, 2017, 7:16 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60879/
> -----------------------------------------------------------
>
> (Updated July 14, 2017, 7:16 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-7777
> https://issues.apache.org/jira/browse/MESOS-7777
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch changes the semancits of `Docker::stop()` to do a best-effort
> `docker rm` and log the error instead of returning the failure, as a
> workaround of the mount namespace leakage issue in Docker 1.12/1.13.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 8ca0c68836ea5d1a1186e79942f6daccf6c6da46
>
>
> Diff: https://reviews.apache.org/r/60879/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>