You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/20 13:39:24 UTC

[GitHub] [tvm-rfcs] manupa-arm edited a comment on pull request #22: [RFC][TIR] TIR Non-scalar Constants

manupa-arm edited a comment on pull request #22:
URL: https://github.com/apache/tvm-rfcs/pull/22#issuecomment-922936589


   Hi @junrushao1994 ,
   
   We have discussed this internally and we find referring to NDArrays in IRModule attributes seems reasonable through tir.allocate_const nodes. I'll do a pass to modify the text in the RFC.
   
   @d-smirnov, any thoughts from you ? -- I think we will have to store the NDArrays as IRModule attrs and cross refer them in the PRs.
   
   If we all agree, I can go ahead and do the RFC changes while @d-smirnov will do the necessary changes in the PRs. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org