You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stephen Connolly (JIRA)" <ji...@apache.org> on 2011/03/09 13:12:59 UTC
[jira] Created: (CASSANDRA-2298) Allow running the build with test
failures ignored
Allow running the build with test failures ignored
--------------------------------------------------
Key: CASSANDRA-2298
URL: https://issues.apache.org/jira/browse/CASSANDRA-2298
Project: Cassandra
Issue Type: Improvement
Components: Core
Affects Versions: 0.8
Reporter: Stephen Connolly
When trying to get code coverage results, if there are failing tests the ANT build will fail.
Need to expose a property to allow ignoring test failures so that code coverage can be recorded despite test failures (as a result of the code being instrumented)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2298) Allow running the build with
test failures ignored
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004811#comment-13004811 ]
Hudson commented on CASSANDRA-2298:
-----------------------------------
Integrated in Cassandra-0.7 #368 (See [https://hudson.apache.org/hudson/job/Cassandra-0.7/368/])
add ant.test.failure.ignore property to optionally allow codecoverage to complete even if tests error out
patch by Stephen Connolly; tested by jbellis for CASSANDRA-2298
> Allow running the build with test failures ignored
> --------------------------------------------------
>
> Key: CASSANDRA-2298
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2298
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.8
> Reporter: Stephen Connolly
> Assignee: Stephen Connolly
> Fix For: 0.7.4
>
> Attachments: CASSANDRA-2298.patch
>
>
> When trying to get code coverage results, if there are failing tests the ANT build will fail.
> Need to expose a property to allow ignoring test failures so that code coverage can be recorded despite test failures (as a result of the code being instrumented)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (CASSANDRA-2298) Allow running the build with test
failures ignored
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reopened CASSANDRA-2298:
---------------------------------------
Assignee: Stephen Connolly
> Allow running the build with test failures ignored
> --------------------------------------------------
>
> Key: CASSANDRA-2298
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2298
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.8
> Reporter: Stephen Connolly
> Assignee: Stephen Connolly
> Attachments: CASSANDRA-2298.patch
>
>
> When trying to get code coverage results, if there are failing tests the ANT build will fail.
> Need to expose a property to allow ignoring test failures so that code coverage can be recorded despite test failures (as a result of the code being instrumented)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2298) Allow running the build with
test failures ignored
Posted by "Stephen Connolly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004771#comment-13004771 ]
Stephen Connolly commented on CASSANDRA-2298:
---------------------------------------------
@Gary.
Nope it does not duplicate CASSANDRA-2258.
2258 is a legitimate bug, this is required to support tracking and trending code coverage from the CI build server in the light of issues such as 2258 arising
> Allow running the build with test failures ignored
> --------------------------------------------------
>
> Key: CASSANDRA-2298
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2298
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.8
> Reporter: Stephen Connolly
> Attachments: CASSANDRA-2298.patch
>
>
> When trying to get code coverage results, if there are failing tests the ANT build will fail.
> Need to expose a property to allow ignoring test failures so that code coverage can be recorded despite test failures (as a result of the code being instrumented)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (CASSANDRA-2298) Allow running the build with test
failures ignored
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-2298.
---------------------------------------
Resolution: Fixed
Fix Version/s: 0.7.4
Reviewer: jbellis
committed
> Allow running the build with test failures ignored
> --------------------------------------------------
>
> Key: CASSANDRA-2298
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2298
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.8
> Reporter: Stephen Connolly
> Assignee: Stephen Connolly
> Fix For: 0.7.4
>
> Attachments: CASSANDRA-2298.patch
>
>
> When trying to get code coverage results, if there are failing tests the ANT build will fail.
> Need to expose a property to allow ignoring test failures so that code coverage can be recorded despite test failures (as a result of the code being instrumented)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2298) Allow running the build with test
failures ignored
Posted by "Stephen Connolly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephen Connolly updated CASSANDRA-2298:
----------------------------------------
Attachment: CASSANDRA-2298.patch
Attached patch will effect the request if the property "ant.test.failure.ignore" is defined
> Allow running the build with test failures ignored
> --------------------------------------------------
>
> Key: CASSANDRA-2298
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2298
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.8
> Reporter: Stephen Connolly
> Attachments: CASSANDRA-2298.patch
>
>
> When trying to get code coverage results, if there are failing tests the ANT build will fail.
> Need to expose a property to allow ignoring test failures so that code coverage can be recorded despite test failures (as a result of the code being instrumented)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2298) Allow running the build with
test failures ignored
Posted by "Stephen Connolly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004768#comment-13004768 ]
Stephen Connolly commented on CASSANDRA-2298:
---------------------------------------------
perhaps... but i prefer not to force the issue and let the CI build define whether it wants the test failures to be ignored. That way you can have a set of different criteria.
Instrumented tests failing can actually be indicative of a number of threading issues.
I just want something that lets the CI build get code coverage... some people (including me depending on the way the wind is blowing) feel that code coverage when tests are failing is invalid as you are executing code paths that are not actually covered by the tests. We had a system which had about 3% higher coverage if 3 of the test cases were failing than if they were passing... so in general you only trust test coverage when the tests pass
> Allow running the build with test failures ignored
> --------------------------------------------------
>
> Key: CASSANDRA-2298
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2298
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.8
> Reporter: Stephen Connolly
> Attachments: CASSANDRA-2298.patch
>
>
> When trying to get code coverage results, if there are failing tests the ANT build will fail.
> Need to expose a property to allow ignoring test failures so that code coverage can be recorded despite test failures (as a result of the code being instrumented)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2298) Allow running the build with
test failures ignored
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004765#comment-13004765 ]
Jonathan Ellis commented on CASSANDRA-2298:
-------------------------------------------
shouldn't codecoverage task automatically define ant.test.failure.ignore?
> Allow running the build with test failures ignored
> --------------------------------------------------
>
> Key: CASSANDRA-2298
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2298
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.8
> Reporter: Stephen Connolly
> Attachments: CASSANDRA-2298.patch
>
>
> When trying to get code coverage results, if there are failing tests the ANT build will fail.
> Need to expose a property to allow ignoring test failures so that code coverage can be recorded despite test failures (as a result of the code being instrumented)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira